2018-10-23 13:23:48

by zhong jiang

Subject: [PATCH] ocfs2: dlmfs: remove set but not used variable 'status'

status is not used after setting its value. It is safe to remove
the unused variable.

Signed-off-by: zhong jiang <[email protected]>
---
fs/ocfs2/dlmfs/dlmfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c
index 642e471..b03dd46 100644
--- a/fs/ocfs2/dlmfs/dlmfs.c
+++ b/fs/ocfs2/dlmfs/dlmfs.c
@@ -179,7 +179,7 @@ static int dlmfs_file_open(struct inode *inode,
static int dlmfs_file_release(struct inode *inode,
struct file *file)
{
- int level, status;
+ int level;
struct dlmfs_inode_private *ip = DLMFS_I(inode);
struct dlmfs_filp_private *fp = file->private_data;

@@ -188,7 +188,6 @@ static int dlmfs_file_release(struct inode *inode,

mlog(0, "close called on inode %lu\n", inode->i_ino);

- status = 0;
if (fp) {
level = fp->fp_lock_level;
if (level != DLM_LOCK_IV)
--
1.7.12.4

2018-10-24 04:44:42

by piaojun

Subject: Re: [PATCH] ocfs2: dlmfs: remove set but not used variable 'status'

LGTM

On 2018/10/23 21:09, zhong jiang wrote:
> status is not used after setting its value. It is safe to remove
> the unused variable.
>
> Signed-off-by: zhong jiang <[email protected]>
Reviewed-by: Jun Piao <[email protected]>
> ---
> fs/ocfs2/dlmfs/dlmfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c
> index 642e471..b03dd46 100644
> --- a/fs/ocfs2/dlmfs/dlmfs.c
> +++ b/fs/ocfs2/dlmfs/dlmfs.c
> @@ -179,7 +179,7 @@ static int dlmfs_file_open(struct inode *inode,
> static int dlmfs_file_release(struct inode *inode,
> struct file *file)
> {
> - int level, status;
> + int level;
> struct dlmfs_inode_private *ip = DLMFS_I(inode);
> struct dlmfs_filp_private *fp = file->private_data;
>
> @@ -188,7 +188,6 @@ static int dlmfs_file_release(struct inode *inode,
>
> mlog(0, "close called on inode %lu\n", inode->i_ino);
>
> - status = 0;
> if (fp) {
> level = fp->fp_lock_level;
> if (level != DLM_LOCK_IV)
>

2018-10-24 10:40:53

by Joseph Qi

Subject: Re: [PATCH] ocfs2: dlmfs: remove set but not used variable 'status'

On 18/10/23 21:09, zhong jiang wrote:
> status is not used after setting its value. It is safe to remove
> the unused variable.
>
> Signed-off-by: zhong jiang <[email protected]>

Acked-by: Joseph Qi <[email protected]>

> ---
> fs/ocfs2/dlmfs/dlmfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/dlmfs/dlmfs.c b/fs/ocfs2/dlmfs/dlmfs.c
> index 642e471..b03dd46 100644
> --- a/fs/ocfs2/dlmfs/dlmfs.c
> +++ b/fs/ocfs2/dlmfs/dlmfs.c
> @@ -179,7 +179,7 @@ static int dlmfs_file_open(struct inode *inode,
> static int dlmfs_file_release(struct inode *inode,
> struct file *file)
> {
> - int level, status;
> + int level;
> struct dlmfs_inode_private *ip = DLMFS_I(inode);
> struct dlmfs_filp_private *fp = file->private_data;
>
> @@ -188,7 +188,6 @@ static int dlmfs_file_release(struct inode *inode,
>
> mlog(0, "close called on inode %lu\n", inode->i_ino);
>
> - status = 0;
> if (fp) {
> level = fp->fp_lock_level;
> if (level != DLM_LOCK_IV)
>