2019-10-23 07:05:58

by Zhou Yanjie

Subject: [PATCH RESEND 2/2] dmaengine: JZ4780: Add support for the X1000.

Add support for probing the dma-jz4780 driver on the X1000 Soc.

Signed-off-by: Zhou Yanjie <[email protected]>
---
drivers/dma/dma-jz4780.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
index cafb1cc0..f809a6e 100644
--- a/drivers/dma/dma-jz4780.c
+++ b/drivers/dma/dma-jz4780.c
@@ -1019,11 +1019,18 @@ static const struct jz4780_dma_soc_data jz4780_dma_soc_data = {
.flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA,
};

+static const struct jz4780_dma_soc_data x1000_dma_soc_data = {
+ .nb_channels = 8,
+ .transfer_ord_max = 7,
+ .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA,
+};
+
static const struct of_device_id jz4780_dma_dt_match[] = {
{ .compatible = "ingenic,jz4740-dma", .data = &jz4740_dma_soc_data },
{ .compatible = "ingenic,jz4725b-dma", .data = &jz4725b_dma_soc_data },
{ .compatible = "ingenic,jz4770-dma", .data = &jz4770_dma_soc_data },
{ .compatible = "ingenic,jz4780-dma", .data = &jz4780_dma_soc_data },
+ { .compatible = "ingenic,x1000-dma", .data = &x1000_dma_soc_data },
{},
};
MODULE_DEVICE_TABLE(of, jz4780_dma_dt_match);
--
2.7.4

2019-10-24 07:08:37

by Paul Cercueil

Subject: Re: [PATCH RESEND 2/2] dmaengine: JZ4780: Add support for the X1000.

Hi Zhou,


Le mer., oct. 23, 2019 at 15:02, Zhou Yanjie <[email protected]> a
?crit :
> Add support for probing the dma-jz4780 driver on the X1000 Soc.
>
> Signed-off-by: Zhou Yanjie <[email protected]>
> ---
> drivers/dma/dma-jz4780.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index cafb1cc0..f809a6e 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -1019,11 +1019,18 @@ static const struct jz4780_dma_soc_data
> jz4780_dma_soc_data = {
> .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA,
> };
>
> +static const struct jz4780_dma_soc_data x1000_dma_soc_data = {
> + .nb_channels = 8,
> + .transfer_ord_max = 7,
> + .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT | JZ_SOC_DATA_PROGRAMMABLE_DMA,

Please don't use JZ_SOC_DATA_ALLOW_LEGACY_DT for new bindings.

With that flag removed:
Reviewed-by: Paul Cercueil <[email protected]>


> +};
> +
> static const struct of_device_id jz4780_dma_dt_match[] = {
> { .compatible = "ingenic,jz4740-dma", .data = &jz4740_dma_soc_data
> },
> { .compatible = "ingenic,jz4725b-dma", .data =
> &jz4725b_dma_soc_data },
> { .compatible = "ingenic,jz4770-dma", .data = &jz4770_dma_soc_data
> },
> { .compatible = "ingenic,jz4780-dma", .data = &jz4780_dma_soc_data
> },
> + { .compatible = "ingenic,x1000-dma", .data = &x1000_dma_soc_data },
> {},
> };
> MODULE_DEVICE_TABLE(of, jz4780_dma_dt_match);
> --
> 2.7.4
>
>

2019-10-25 01:44:04

by Zhou Yanjie

Subject: Re: [PATCH RESEND 2/2] dmaengine: JZ4780: Add support for the X1000.

Hi Paul,

On 2019年10月24日 00:08, Paul Cercueil wrote:
> Hi Zhou,
>
>
> Le mer., oct. 23, 2019 at 15:02, Zhou Yanjie <[email protected]> a
> écrit :
>> Add support for probing the dma-jz4780 driver on the X1000 Soc.
>>
>> Signed-off-by: Zhou Yanjie <[email protected]>
>> ---
>> drivers/dma/dma-jz4780.c | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
>> index cafb1cc0..f809a6e 100644
>> --- a/drivers/dma/dma-jz4780.c
>> +++ b/drivers/dma/dma-jz4780.c
>> @@ -1019,11 +1019,18 @@ static const struct jz4780_dma_soc_data
>> jz4780_dma_soc_data = {
>> .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT |
>> JZ_SOC_DATA_PROGRAMMABLE_DMA,
>> };
>>
>> +static const struct jz4780_dma_soc_data x1000_dma_soc_data = {
>> + .nb_channels = 8,
>> + .transfer_ord_max = 7,
>> + .flags = JZ_SOC_DATA_ALLOW_LEGACY_DT |
>> JZ_SOC_DATA_PROGRAMMABLE_DMA,
>
> Please don't use JZ_SOC_DATA_ALLOW_LEGACY_DT for new bindings.
>
> With that flag removed:
> Reviewed-by: Paul Cercueil <[email protected]>
>

I'll remove it in v2.

Best regards!

>
>> +};
>> +
>> static const struct of_device_id jz4780_dma_dt_match[] = {
>> { .compatible = "ingenic,jz4740-dma", .data =
>> &jz4740_dma_soc_data },
>> { .compatible = "ingenic,jz4725b-dma", .data =
>> &jz4725b_dma_soc_data },
>> { .compatible = "ingenic,jz4770-dma", .data =
>> &jz4770_dma_soc_data },
>> { .compatible = "ingenic,jz4780-dma", .data =
>> &jz4780_dma_soc_data },
>> + { .compatible = "ingenic,x1000-dma", .data = &x1000_dma_soc_data },
>> {},
>> };
>> MODULE_DEVICE_TABLE(of, jz4780_dma_dt_match);
>> --
>> 2.7.4
>>
>>
>
>