2020-02-26 01:14:02

by Xiao Yang

Subject: [PATCH v2] tools/perf/util/*.c: Use "%zu" output format for size_t type

Avoid the following errors when building perf on i386:
-----------------------------------------------
util/session.c: In function 'perf_session__process_compressed_event':
util/session.c:91:11: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=]
pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size);
...
til/zstd.c: In function 'zstd_decompress_stream':
util/zstd.c:102:11: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=]
pr_err("failed to decompress (B): %ld -> %ld, dst_size %ld : %s\n",
...
-----------------------------------------------

Reported-by: kernel test robot <[email protected]>
Signed-off-by: Xiao Yang <[email protected]>
---
tools/perf/util/session.c | 2 +-
tools/perf/util/zstd.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index d0d7d25b23e3..55c3d2fefd41 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -88,7 +88,7 @@ static int perf_session__process_compressed_event(struct perf_session *session,
session->decomp_last = decomp;
}

- pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size);
+ pr_debug("decomp (B): %zu to %zu\n", src_size, decomp_size);

return 0;
}
diff --git a/tools/perf/util/zstd.c b/tools/perf/util/zstd.c
index d2202392ffdb..a051237cacf2 100644
--- a/tools/perf/util/zstd.c
+++ b/tools/perf/util/zstd.c
@@ -99,7 +99,7 @@ size_t zstd_decompress_stream(struct zstd_data *data, void *src, size_t src_size
while (input.pos < input.size) {
ret = ZSTD_decompressStream(data->dstream, &output, &input);
if (ZSTD_isError(ret)) {
- pr_err("failed to decompress (B): %ld -> %ld, dst_size %ld : %s\n",
+ pr_err("failed to decompress (B): %zu -> %zu, dst_size %zu : %s\n",
src_size, output.size, dst_size, ZSTD_getErrorName(ret));
break;
}
--
2.21.0

2020-05-12 02:15:09

by Xiao Yang

Subject: Re: [PATCH v2] tools/perf/util/*.c: Use "%zu" output format for size_t type

Hi,

Ping!

Thanks,
Xiao Yang
On 2020/2/26 9:08, Xiao Yang wrote:
> Avoid the following errors when building perf on i386:
> -----------------------------------------------
> util/session.c: In function 'perf_session__process_compressed_event':
> util/session.c:91:11: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=]
> pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size);
> ...
> til/zstd.c: In function 'zstd_decompress_stream':
> util/zstd.c:102:11: error: format '%ld' expects argument of type 'long int', but argument 4 has type 'size_t {aka unsigned int}' [-Werror=format=]
> pr_err("failed to decompress (B): %ld -> %ld, dst_size %ld : %s\n",
> ...
> -----------------------------------------------
>
> Reported-by: kernel test robot<[email protected]>
> Signed-off-by: Xiao Yang<[email protected]>
> ---
> tools/perf/util/session.c | 2 +-
> tools/perf/util/zstd.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
> index d0d7d25b23e3..55c3d2fefd41 100644
> --- a/tools/perf/util/session.c
> +++ b/tools/perf/util/session.c
> @@ -88,7 +88,7 @@ static int perf_session__process_compressed_event(struct perf_session *session,
> session->decomp_last = decomp;
> }
>
> - pr_debug("decomp (B): %ld to %ld\n", src_size, decomp_size);
> + pr_debug("decomp (B): %zu to %zu\n", src_size, decomp_size);
>
> return 0;
> }
> diff --git a/tools/perf/util/zstd.c b/tools/perf/util/zstd.c
> index d2202392ffdb..a051237cacf2 100644
> --- a/tools/perf/util/zstd.c
> +++ b/tools/perf/util/zstd.c
> @@ -99,7 +99,7 @@ size_t zstd_decompress_stream(struct zstd_data *data, void *src, size_t src_size
> while (input.pos< input.size) {
> ret = ZSTD_decompressStream(data->dstream,&output,&input);
> if (ZSTD_isError(ret)) {
> - pr_err("failed to decompress (B): %ld -> %ld, dst_size %ld : %s\n",
> + pr_err("failed to decompress (B): %zu -> %zu, dst_size %zu : %s\n",
> src_size, output.size, dst_size, ZSTD_getErrorName(ret));
> break;
> }