2018-01-02 02:50:52

by Stephen Rothwell

Subject: linux-next: build warning after merge of the tpmdd tree

Hi Jarkko,

After merging the tpmdd tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
drivers/char/tpm/tpm_tis.c:274:23: warning: unused variable 'priv' [-Wunused-variable]
struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
^
drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
drivers/char/tpm/tpm_tis.c:324:23: warning: unused variable 'priv' [-Wunused-variable]
struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
^

Introduced by commit

6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()")

--
Cheers,
Stephen Rothwell

2018-01-02 04:05:55

by Azhar Shaikh

Subject: RE: linux-next: build warning after merge of the tpmdd tree

Hi Stephen,

Thanks for reporting this.

I have uploaded new patchset to tpmdd mailing list.

Regards,
Azhar Shaikh

>-----Original Message-----
>From: Stephen Rothwell [mailto:[email protected]]
>Sent: Monday, January 1, 2018 6:51 PM
>To: Jarkko Sakkinen <[email protected]>
>Cc: Linux-Next Mailing List <[email protected]>; Linux Kernel Mailing
>List <[email protected]>; Shaikh, Azhar <[email protected]>
>Subject: linux-next: build warning after merge of the tpmdd tree
>
>Hi Jarkko,
>
>After merging the tpmdd tree, today's linux-next build (x86_64
>allmodconfig) produced this warning:
>
>drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_pnp_remove':
>drivers/char/tpm/tpm_tis.c:274:23: warning: unused variable 'priv' [-
>Wunused-variable]
> struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
> ^
>drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_plat_remove':
>drivers/char/tpm/tpm_tis.c:324:23: warning: unused variable 'priv' [-
>Wunused-variable]
> struct tpm_tis_data *priv = dev_get_drvdata(&chip->dev);
> ^
>
>Introduced by commit
>
> 6d0866cbc2d3 ("tpm: Keep CLKRUN enabled throughout the duration of
>transmit_cmd()")
>
>--
>Cheers,
>Stephen Rothwell