2022-08-10 16:53:13

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v4 1/4] dt-bindings: mediatek: watchdog: Fix compatible fallbacks and example

On 21/07/2022 04:48, Allen-KH Cheng wrote:
> The watchdog timer of mt8186. mt8195 and mt7986 have their DT data.
> We should not use 'mediatek,mt6589-wdt' as fallback.
>
> For mediatek,wdt example of mt8183, We remove mediatek,mt6589-wdt fallback.
>
> Fixes:a45b408a020b("dt-bindings: watchdog: Add compatible for MediaTek MT8186")
> Fixes:b326f2c85f3d("dt-bindings: watchdog: Add compatible for Mediatek MT8195")
> Fixes:41e73feb1024("dt-bindings: watchdog: Add compatible for Mediatek MT7986")
> Fixes:f43f97a0fc0e("dt-bindings: mediatek: mt8183: Add #reset-cells")

Missing spaces around SHA.

Best regards,
Krzysztof


2022-08-11 09:10:35

by Allen-KH Cheng

[permalink] [raw]
Subject: Re: [PATCH v4 1/4] dt-bindings: mediatek: watchdog: Fix compatible fallbacks and example

Hi Krzysztof,

On Wed, 2022-08-10 at 19:49 +0300, Krzysztof Kozlowski wrote:
> On 21/07/2022 04:48, Allen-KH Cheng wrote:
> > The watchdog timer of mt8186. mt8195 and mt7986 have their DT data.
> > We should not use 'mediatek,mt6589-wdt' as fallback.
> >
> > For mediatek,wdt example of mt8183, We remove mediatek,mt6589-wdt
> > fallback.
> >
> > Fixes:a45b408a020b("dt-bindings: watchdog: Add compatible for
> > MediaTek MT8186")
> > Fixes:b326f2c85f3d("dt-bindings: watchdog: Add compatible for
> > Mediatek MT8195")
> > Fixes:41e73feb1024("dt-bindings: watchdog: Add compatible for
> > Mediatek MT7986")
> > Fixes:f43f97a0fc0e("dt-bindings: mediatek: mt8183: Add #reset-
> > cells")
>
> Missing spaces around SHA.
>
> Best regards,
> Krzysztof

Thanks for your friendly reminder.

I'll pay more attention in the next time.

Thanks,
Allen