2018-01-14 21:18:56

by SF Markus Elfring

Subject: [PATCH] mfd/janz-cmodio: Delete an error message for a failed memory allocation in cmodio_pci_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 14 Jan 2018 22:15:09 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/janz-cmodio.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/janz-cmodio.c b/drivers/mfd/janz-cmodio.c
index ec1f46a6be3a..317a47ad5bb7 100644
--- a/drivers/mfd/janz-cmodio.c
+++ b/drivers/mfd/janz-cmodio.c
@@ -183,10 +183,8 @@ static int cmodio_pci_probe(struct pci_dev *dev,
int ret;

priv = devm_kzalloc(&dev->dev, sizeof(*priv), GFP_KERNEL);
- if (!priv) {
- dev_err(&dev->dev, "unable to allocate private data\n");
+ if (!priv)
return -ENOMEM;
- }

pci_set_drvdata(dev, priv);
priv->pdev = dev;
--
2.15.1

2018-01-22 15:41:50

by Lee Jones

Subject: Re: [PATCH] mfd/janz-cmodio: Delete an error message for a failed memory allocation in cmodio_pci_probe()

On Sun, 14 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Sun, 14 Jan 2018 22:15:09 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/janz-cmodio.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog