2023-03-30 01:35:33

by Yang Li

Subject: [PATCH -next] EDAC/amd64: clean up some inconsistent indentings

drivers/edac/amd64_edac.c:1279 umc_determine_edac_cap() warn: inconsistent indenting

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4639
Signed-off-by: Yang Li <[email protected]>
---
drivers/edac/amd64_edac.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/edac/amd64_edac.c b/drivers/edac/amd64_edac.c
index 6dad0f1064c0..5c4292e65b96 100644
--- a/drivers/edac/amd64_edac.c
+++ b/drivers/edac/amd64_edac.c
@@ -1276,19 +1276,19 @@ static unsigned long umc_determine_edac_cap(struct amd64_pvt *pvt)
u8 i, umc_en_mask = 0, dimm_ecc_en_mask = 0;
unsigned long edac_cap = EDAC_FLAG_NONE;

- for_each_umc(i) {
- if (!(pvt->umc[i].sdp_ctrl & UMC_SDP_INIT))
- continue;
+ for_each_umc(i) {
+ if (!(pvt->umc[i].sdp_ctrl & UMC_SDP_INIT))
+ continue;

- umc_en_mask |= BIT(i);
+ umc_en_mask |= BIT(i);

- /* UMC Configuration bit 12 (DimmEccEn) */
- if (pvt->umc[i].umc_cfg & BIT(12))
- dimm_ecc_en_mask |= BIT(i);
- }
+ /* UMC Configuration bit 12 (DimmEccEn) */
+ if (pvt->umc[i].umc_cfg & BIT(12))
+ dimm_ecc_en_mask |= BIT(i);
+ }

- if (umc_en_mask == dimm_ecc_en_mask)
- edac_cap = EDAC_FLAG_SECDED;
+ if (umc_en_mask == dimm_ecc_en_mask)
+ edac_cap = EDAC_FLAG_SECDED;

return edac_cap;
}
--
2.20.1.7.g153144c

2023-04-03 17:19:22

by Yazen Ghannam

Subject: Re: [PATCH -next] EDAC/amd64: clean up some inconsistent indentings

On 3/29/23 21:20, Yang Li wrote:
> drivers/edac/amd64_edac.c:1279 umc_determine_edac_cap() warn: inconsistent indenting
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4639
> Signed-off-by: Yang Li <[email protected]>
> ---

Hi Yang,

Thanks for the patch.

It looks like this issue was introduced with the following commit.

f6a4b4a1aa16 ("EDAC/amd64: Split determine_edac_cap() into dct/umc functions")

Can you please include a Fixes tag and describe your changes in the commit message?

Thanks,
Yazen