2018-04-26 16:56:19

by Kieran Bingham

[permalink] [raw]
Subject: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output

From: Takeshi Kihara <[email protected]>

Enable the HDMI encoder for the M3N Salvator-X board and hook it up to
the HDMI connector.

Based on a similar patches of the the Salvator-X board
on the R8A7796 SoC device tree
by Laurent Pinchart <[email protected]>

Signed-off-by: Takeshi Kihara <[email protected]>
Signed-off-by: Kieran Bingham <[email protected]>
---
.../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++
1 file changed, 17 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
index a2b8fb20fef8..11e8d43e9e11 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
@@ -31,3 +31,20 @@
clock-names = "du.0", "du.1", "du.3", "lvds.0",
"dclkin.0", "dclkin.1", "dclkin.3";
};
+
+&hdmi0 {
+ status = "okay";
+
+ ports {
+ port@1 {
+ reg = <1>;
+ rcar_dw_hdmi0_out: endpoint {
+ remote-endpoint = <&hdmi0_con>;
+ };
+ };
+ };
+};
+
+&hdmi0_con {
+ remote-endpoint = <&rcar_dw_hdmi0_out>;
+};
--
2.17.0



2018-04-26 21:24:25

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output

Hi Kieran,

Thank you for the patch.

On Thursday, 26 April 2018 19:53:44 EEST Kieran Bingham wrote:
> From: Takeshi Kihara <[email protected]>
>
> Enable the HDMI encoder for the M3N Salvator-X board and hook it up to
> the HDMI connector.
>
> Based on a similar patches of the the Salvator-X board
> on the R8A7796 SoC device tree
> by Laurent Pinchart <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

How about adding the VGA output too ? I think you can add both VGA and HDMI in
a single patch that enables display in one go for the board. Same comment for
the Salvator-XS.

> Signed-off-by: Takeshi Kihara <[email protected]>
> Signed-off-by: Kieran Bingham <[email protected]>
> ---
> .../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index
> a2b8fb20fef8..11e8d43e9e11 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
> @@ -31,3 +31,20 @@
> clock-names = "du.0", "du.1", "du.3", "lvds.0",
> "dclkin.0", "dclkin.1", "dclkin.3";
> };
> +
> +&hdmi0 {
> + status = "okay";
> +
> + ports {
> + port@1 {
> + reg = <1>;
> + rcar_dw_hdmi0_out: endpoint {
> + remote-endpoint = <&hdmi0_con>;
> + };
> + };
> + };
> +};
> +
> +&hdmi0_con {
> + remote-endpoint = <&rcar_dw_hdmi0_out>;
> +};

--
Regards,

Laurent Pinchart




2018-04-27 16:23:44

by Kieran Bingham

[permalink] [raw]
Subject: Re: [PATCH 15/17] arm64: dts: r8a77965-salvator-x: Enable HDMI output

Hi Laurent,

On 26/04/18 22:21, Laurent Pinchart wrote:
> Hi Kieran,
>
> Thank you for the patch.
>
> On Thursday, 26 April 2018 19:53:44 EEST Kieran Bingham wrote:
>> From: Takeshi Kihara <[email protected]>
>>
>> Enable the HDMI encoder for the M3N Salvator-X board and hook it up to
>> the HDMI connector.
>>
>> Based on a similar patches of the the Salvator-X board
>> on the R8A7796 SoC device tree
>> by Laurent Pinchart <[email protected]>
>
> Reviewed-by: Laurent Pinchart <[email protected]>

Thanks, collected.

>
> How about adding the VGA output too ? I think you can add both VGA and HDMI in
> a single patch that enables display in one go for the board. Same comment for
> the Salvator-XS.

I believe the VGA output is handled by the salvator-common.dtsi, and thus
doesn't need to be included in this patch.

>
>> Signed-off-by: Takeshi Kihara <[email protected]>
>> Signed-off-by: Kieran Bingham <[email protected]>
>> ---
>> .../boot/dts/renesas/r8a77965-salvator-x.dts | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts index
>> a2b8fb20fef8..11e8d43e9e11 100644
>> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-x.dts
>> @@ -31,3 +31,20 @@
>> clock-names = "du.0", "du.1", "du.3", "lvds.0",
>> "dclkin.0", "dclkin.1", "dclkin.3";
>> };
>> +
>> +&hdmi0 {
>> + status = "okay";
>> +
>> + ports {
>> + port@1 {
>> + reg = <1>;
>> + rcar_dw_hdmi0_out: endpoint {
>> + remote-endpoint = <&hdmi0_con>;
>> + };
>> + };
>> + };
>> +};
>> +
>> +&hdmi0_con {
>> + remote-endpoint = <&rcar_dw_hdmi0_out>;
>> +};
>