2021-12-23 07:40:48

by Christophe JAILLET

Subject: [PATCH] usb: dwc2: Simplify a bitmap declaration

Use DECLARE_BITMAP() instead of hand writing it.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/usb/dwc2/core.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index e2fe64239328..8a63da3ab39d 100644
--- a/drivers/usb/dwc2/core.h
+++ b/drivers/usb/dwc2/core.h
@@ -1154,8 +1154,7 @@ struct dwc2_hsotg {
struct list_head periodic_sched_queued;
struct list_head split_order;
u16 periodic_usecs;
- unsigned long hs_periodic_bitmap[
- DIV_ROUND_UP(DWC2_HS_SCHEDULE_US, BITS_PER_LONG)];
+ DECLARE_BITMAP(hs_periodic_bitmap, DWC2_HS_SCHEDULE_US);
u16 periodic_qh_count;
bool new_connection;

--
2.32.0

2022-01-04 07:40:01

by Minas Harutyunyan

Subject: Re: [PATCH] usb: dwc2: Simplify a bitmap declaration

On 12/23/2021 11:40 AM, Christophe JAILLET wrote:
> Use DECLARE_BITMAP() instead of hand writing it.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Acked-by: Minas Harutyunyan <[email protected]>

> ---
> drivers/usb/dwc2/core.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
> index e2fe64239328..8a63da3ab39d 100644
> --- a/drivers/usb/dwc2/core.h
> +++ b/drivers/usb/dwc2/core.h
> @@ -1154,8 +1154,7 @@ struct dwc2_hsotg {
> struct list_head periodic_sched_queued;
> struct list_head split_order;
> u16 periodic_usecs;
> - unsigned long hs_periodic_bitmap[
> - DIV_ROUND_UP(DWC2_HS_SCHEDULE_US, BITS_PER_LONG)];
> + DECLARE_BITMAP(hs_periodic_bitmap, DWC2_HS_SCHEDULE_US);
> u16 periodic_qh_count;
> bool new_connection;
>