REGMAP is a hidden (not user visible) symbol. Users cannot set it
directly thru "make *config", so drivers should select it instead of
depending on it if they need it.
Consistently using "select" or "depends on" can also help reduce
Kconfig circular dependency issues.
REGMAP is selected 94 times and is depended on 11 times in
current linux-next. Eliminate the uses of "depends on" by
converting them to "select".
[PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
[PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
[PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
[PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
[PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
[PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
[PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
[PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
diffstat:
drivers/char/ipmi/Kconfig | 3 ++-
drivers/clk/Kconfig | 2 +-
drivers/gpio/Kconfig | 2 +-
drivers/leds/Kconfig | 2 +-
drivers/platform/mellanox/Kconfig | 9 ++++-----
drivers/platform/x86/Kconfig | 3 ++-
drivers/thermal/intel/Kconfig | 3 ++-
drivers/tty/serial/8250/Kconfig | 3 ++-
8 files changed, 15 insertions(+), 12 deletions(-)
Cc: Andrew Jeffery <[email protected]>
Cc: Corey Minyard <[email protected]>
Cc: [email protected]
Cc: Arnd Bergmann <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Riku Voipio <[email protected]>
Cc: Stephen Boyd <[email protected]>
Cc: Michael Turquette <[email protected]>
Cc: [email protected]
Cc: Michael Walle <[email protected]>
Cc: Linus Walleij <[email protected]>
Cc: Bartosz Golaszewski <[email protected]>
Cc: [email protected]
Cc: Dan Murphy <[email protected]>
Cc: Pavel Machek <[email protected]>
Cc: Jacek Anaszewski <[email protected]>
Cc: Lee Jones <[email protected]>
Cc: [email protected]
Cc: Darren Hart <[email protected]>
Cc: Hans de Goede <[email protected]>
Cc: Michael Shych <[email protected]>
Cc: Mark Gross <[email protected]>
Cc: Vadim Pasternak <[email protected]>
Cc: [email protected]
Cc: Yegnesh S Iyer <[email protected]>
Cc: Bin Gao <[email protected]>
Cc: Zhang Rui <[email protected]>
Cc: "Rafael J. Wysocki" <[email protected]>
Cc: Daniel Lezcano <[email protected]>
Cc: Amit Kucheria <[email protected]>
Cc: [email protected]
Cc: Oskar Senft <[email protected]>
Cc: [email protected]
Hi Randy,
On 2/26/23 06:39, Randy Dunlap wrote:
> REGMAP is a hidden (not user visible) symbol. Users cannot set it
> directly thru "make *config", so drivers should select it instead of
> depending on it if they need it.
>
> Consistently using "select" or "depends on" can also help reduce
> Kconfig circular dependency issues.
>
> REGMAP is selected 94 times and is depended on 11 times in
> current linux-next. Eliminate the uses of "depends on" by
> converting them to "select".
Thank you for your work on this. Mixing of depends on vs select
is a real problem with many Kconfig symbols.
> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
For patch 5/8 and 6/8, do you want me to merge them through the pdx86
(platform-drivers-x86) tree, or do you plan to merge this whole series
in one go through some other tree?
If you plan to merge the whole series through some other tree,
here is my acked by for doing so for 5/8 and 6/8:
Acked-by: Hans de Goede <[email protected]>
Regards,
Hans
>
> diffstat:
> drivers/char/ipmi/Kconfig | 3 ++-
> drivers/clk/Kconfig | 2 +-
> drivers/gpio/Kconfig | 2 +-
> drivers/leds/Kconfig | 2 +-
> drivers/platform/mellanox/Kconfig | 9 ++++-----
> drivers/platform/x86/Kconfig | 3 ++-
> drivers/thermal/intel/Kconfig | 3 ++-
> drivers/tty/serial/8250/Kconfig | 3 ++-
> 8 files changed, 15 insertions(+), 12 deletions(-)
>
> Cc: Andrew Jeffery <[email protected]>
> Cc: Corey Minyard <[email protected]>
> Cc: [email protected]
> Cc: Arnd Bergmann <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Riku Voipio <[email protected]>
> Cc: Stephen Boyd <[email protected]>
> Cc: Michael Turquette <[email protected]>
> Cc: [email protected]
> Cc: Michael Walle <[email protected]>
> Cc: Linus Walleij <[email protected]>
> Cc: Bartosz Golaszewski <[email protected]>
> Cc: [email protected]
> Cc: Dan Murphy <[email protected]>
> Cc: Pavel Machek <[email protected]>
> Cc: Jacek Anaszewski <[email protected]>
> Cc: Lee Jones <[email protected]>
> Cc: [email protected]
> Cc: Darren Hart <[email protected]>
> Cc: Hans de Goede <[email protected]>
> Cc: Michael Shych <[email protected]>
> Cc: Mark Gross <[email protected]>
> Cc: Vadim Pasternak <[email protected]>
> Cc: [email protected]
> Cc: Yegnesh S Iyer <[email protected]>
> Cc: Bin Gao <[email protected]>
> Cc: Zhang Rui <[email protected]>
> Cc: "Rafael J. Wysocki" <[email protected]>
> Cc: Daniel Lezcano <[email protected]>
> Cc: Amit Kucheria <[email protected]>
> Cc: [email protected]
> Cc: Oskar Senft <[email protected]>
> Cc: [email protected]
>
On 2/27/23 01:31, Hans de Goede wrote:
> Hi Randy,
>
> On 2/26/23 06:39, Randy Dunlap wrote:
>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>> directly thru "make *config", so drivers should select it instead of
>> depending on it if they need it.
>>
>> Consistently using "select" or "depends on" can also help reduce
>> Kconfig circular dependency issues.
>>
>> REGMAP is selected 94 times and is depended on 11 times in
>> current linux-next. Eliminate the uses of "depends on" by
>> converting them to "select".
>
> Thank you for your work on this. Mixing of depends on vs select
> is a real problem with many Kconfig symbols.
>
>> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
>> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
>> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
>> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
>> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
>> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
>> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
>> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
>
> For patch 5/8 and 6/8, do you want me to merge them through the pdx86
> (platform-drivers-x86) tree, or do you plan to merge this whole series
> in one go through some other tree?
Hi Hans,
Please merge them thru the pdx86 tree.
Thanks.
> If you plan to merge the whole series through some other tree,
> here is my acked by for doing so for 5/8 and 6/8:
>
> Acked-by: Hans de Goede <[email protected]>
>
> Regards,
>
> Hans
>
>
>
>
>>
>> diffstat:
>> drivers/char/ipmi/Kconfig | 3 ++-
>> drivers/clk/Kconfig | 2 +-
>> drivers/gpio/Kconfig | 2 +-
>> drivers/leds/Kconfig | 2 +-
>> drivers/platform/mellanox/Kconfig | 9 ++++-----
>> drivers/platform/x86/Kconfig | 3 ++-
>> drivers/thermal/intel/Kconfig | 3 ++-
>> drivers/tty/serial/8250/Kconfig | 3 ++-
>> 8 files changed, 15 insertions(+), 12 deletions(-)
>>
>> Cc: Andrew Jeffery <[email protected]>
>> Cc: Corey Minyard <[email protected]>
>> Cc: [email protected]
>> Cc: Arnd Bergmann <[email protected]>
>> Cc: Greg Kroah-Hartman <[email protected]>
>> Cc: Riku Voipio <[email protected]>
>> Cc: Stephen Boyd <[email protected]>
>> Cc: Michael Turquette <[email protected]>
>> Cc: [email protected]
>> Cc: Michael Walle <[email protected]>
>> Cc: Linus Walleij <[email protected]>
>> Cc: Bartosz Golaszewski <[email protected]>
>> Cc: [email protected]
>> Cc: Dan Murphy <[email protected]>
>> Cc: Pavel Machek <[email protected]>
>> Cc: Jacek Anaszewski <[email protected]>
>> Cc: Lee Jones <[email protected]>
>> Cc: [email protected]
>> Cc: Darren Hart <[email protected]>
>> Cc: Hans de Goede <[email protected]>
>> Cc: Michael Shych <[email protected]>
>> Cc: Mark Gross <[email protected]>
>> Cc: Vadim Pasternak <[email protected]>
>> Cc: [email protected]
>> Cc: Yegnesh S Iyer <[email protected]>
>> Cc: Bin Gao <[email protected]>
>> Cc: Zhang Rui <[email protected]>
>> Cc: "Rafael J. Wysocki" <[email protected]>
>> Cc: Daniel Lezcano <[email protected]>
>> Cc: Amit Kucheria <[email protected]>
>> Cc: [email protected]
>> Cc: Oskar Senft <[email protected]>
>> Cc: [email protected]
>>
>
--
~Randy
Hi,
On 2/27/23 17:07, Randy Dunlap wrote:
>
>
> On 2/27/23 01:31, Hans de Goede wrote:
>> Hi Randy,
>>
>> On 2/26/23 06:39, Randy Dunlap wrote:
>>> REGMAP is a hidden (not user visible) symbol. Users cannot set it
>>> directly thru "make *config", so drivers should select it instead of
>>> depending on it if they need it.
>>>
>>> Consistently using "select" or "depends on" can also help reduce
>>> Kconfig circular dependency issues.
>>>
>>> REGMAP is selected 94 times and is depended on 11 times in
>>> current linux-next. Eliminate the uses of "depends on" by
>>> converting them to "select".
>>
>> Thank you for your work on this. Mixing of depends on vs select
>> is a real problem with many Kconfig symbols.
>>
>>> [PATCH 1/8] ipmi: ASPEED_BT_IPMI_BMC: select REGMAP_MMIO instead of depending on it
>>> [PATCH 2/8] clk: HI655X: select REGMAP instead of depending on it
>>> [PATCH 3/8] gpio: GPIO_REGMAP: select REGMAP instead of depending on it
>>> [PATCH 4/8] leds: TI_LMU_COMMON: select REGMAP instead of depending on it
>>> [PATCH 5/8] platform: mellanox: select REGMAP instead of depending on it
>>> [PATCH 6/8] platform: x86: MLX_PLATFORM: select REGMAP instead of depending on it
>>> [PATCH 7/8] thermal: intel: BXT_PMIC: select REGMAP instead of depending on it
>>> [PATCH 8/8] serial: 8250: ASPEED_VUART: select REGMAP instead of depending on it
>>
>> For patch 5/8 and 6/8, do you want me to merge them through the pdx86
>> (platform-drivers-x86) tree, or do you plan to merge this whole series
>> in one go through some other tree?
>
> Hi Hans,
> Please merge them thru the pdx86 tree.
Ok, I've applied patch 5/8 + 6/8 to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
I'll rebase that branch once 6.3-rc1 is out and then push the rebased
patch to the fixes branch and include it in my next 6.3 fixes pull-req
to Linus.
Regards,
Hans
>>>
>>> diffstat:
>>> drivers/char/ipmi/Kconfig | 3 ++-
>>> drivers/clk/Kconfig | 2 +-
>>> drivers/gpio/Kconfig | 2 +-
>>> drivers/leds/Kconfig | 2 +-
>>> drivers/platform/mellanox/Kconfig | 9 ++++-----
>>> drivers/platform/x86/Kconfig | 3 ++-
>>> drivers/thermal/intel/Kconfig | 3 ++-
>>> drivers/tty/serial/8250/Kconfig | 3 ++-
>>> 8 files changed, 15 insertions(+), 12 deletions(-)
>>>
>>> Cc: Andrew Jeffery <[email protected]>
>>> Cc: Corey Minyard <[email protected]>
>>> Cc: [email protected]
>>> Cc: Arnd Bergmann <[email protected]>
>>> Cc: Greg Kroah-Hartman <[email protected]>
>>> Cc: Riku Voipio <[email protected]>
>>> Cc: Stephen Boyd <[email protected]>
>>> Cc: Michael Turquette <[email protected]>
>>> Cc: [email protected]
>>> Cc: Michael Walle <[email protected]>
>>> Cc: Linus Walleij <[email protected]>
>>> Cc: Bartosz Golaszewski <[email protected]>
>>> Cc: [email protected]
>>> Cc: Dan Murphy <[email protected]>
>>> Cc: Pavel Machek <[email protected]>
>>> Cc: Jacek Anaszewski <[email protected]>
>>> Cc: Lee Jones <[email protected]>
>>> Cc: [email protected]
>>> Cc: Darren Hart <[email protected]>
>>> Cc: Hans de Goede <[email protected]>
>>> Cc: Michael Shych <[email protected]>
>>> Cc: Mark Gross <[email protected]>
>>> Cc: Vadim Pasternak <[email protected]>
>>> Cc: [email protected]
>>> Cc: Yegnesh S Iyer <[email protected]>
>>> Cc: Bin Gao <[email protected]>
>>> Cc: Zhang Rui <[email protected]>
>>> Cc: "Rafael J. Wysocki" <[email protected]>
>>> Cc: Daniel Lezcano <[email protected]>
>>> Cc: Amit Kucheria <[email protected]>
>>> Cc: [email protected]
>>> Cc: Oskar Senft <[email protected]>
>>> Cc: [email protected]
>>>
>>
>