2020-12-09 07:28:12

by Sameer Pujar

[permalink] [raw]
Subject: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

The remote-endpoint may not be available if it is part of some
pluggable module. One such example would be an audio card, the
Codec endpoint will not be available until it is plugged in.
Hence drop 'remote-endpoint' as a required property.

Cc: Rob Herring <[email protected]>
Cc: Kuninori Morimoto <[email protected]>
Signed-off-by: Sameer Pujar <[email protected]>
---
Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 ---
1 file changed, 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
index 2005014..766e910 100644
--- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
+++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
@@ -71,9 +71,6 @@ properties:
description: CPU to Codec rate channels.
$ref: /schemas/types.yaml#/definitions/uint32

- required:
- - remote-endpoint
-
ports:
description: multi OF-Graph subnode
type: object
--
2.7.4


2020-12-10 02:47:19

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

On Wed, Dec 09, 2020 at 12:52:12PM +0530, Sameer Pujar wrote:
> The remote-endpoint may not be available if it is part of some
> pluggable module. One such example would be an audio card, the
> Codec endpoint will not be available until it is plugged in.
> Hence drop 'remote-endpoint' as a required property.

Please hold off on this. I have more changes coming.

>
> Cc: Rob Herring <[email protected]>
> Cc: Kuninori Morimoto <[email protected]>
> Signed-off-by: Sameer Pujar <[email protected]>
> ---
> Documentation/devicetree/bindings/sound/audio-graph-port.yaml | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> index 2005014..766e910 100644
> --- a/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> +++ b/Documentation/devicetree/bindings/sound/audio-graph-port.yaml
> @@ -71,9 +71,6 @@ properties:
> description: CPU to Codec rate channels.
> $ref: /schemas/types.yaml#/definitions/uint32
>
> - required:
> - - remote-endpoint
> -
> ports:
> description: multi OF-Graph subnode
> type: object
> --
> 2.7.4
>

2020-12-11 07:10:44

by Sameer Pujar

[permalink] [raw]
Subject: Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

Hi Rob,

>> The remote-endpoint may not be available if it is part of some
>> pluggable module. One such example would be an audio card, the
>> Codec endpoint will not be available until it is plugged in.
>> Hence drop 'remote-endpoint' as a required property.
> Please hold off on this. I have more changes coming.

OK, I will wait for your patch. Kindly note that this is currently
blocking series
https://patchwork.kernel.org/project/alsa-devel/list/?series=391735&state=*

Thanks,
Sameer.

2020-12-28 06:50:08

by Sameer Pujar

[permalink] [raw]
Subject: Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

Hi Rob,

>>> The remote-endpoint may not be available if it is part of some
>>> pluggable module. One such example would be an audio card, the
>>> Codec endpoint will not be available until it is plugged in.
>>> Hence drop 'remote-endpoint' as a required property.
>> Please hold off on this. I have more changes coming.

Is this a good time to push for audio-graph-port changes?

2021-01-11 04:52:43

by Sameer Pujar

[permalink] [raw]
Subject: Re: [PATCH] ASoC: audio-graph-card: Drop remote-endpoint as required property

Hi Rob,


On 12/10/2020 8:14 PM, Sameer Pujar wrote:
> Hi Rob,
>
>>> The remote-endpoint may not be available if it is part of some
>>> pluggable module. One such example would be an audio card, the
>>> Codec endpoint will not be available until it is plugged in.
>>> Hence drop 'remote-endpoint' as a required property.
>> Please hold off on this. I have more changes coming.

Sorry to bother you again. Is it possible if we take this patch now and
your remaining changes can come later? This would help to unblock below
series, which is pending quite some time now.

>
> OK, I will wait for your patch. Kindly note that this is currently
> blocking series
> https://patchwork.kernel.org/project/alsa-devel/list/?series=391735&state=*