2020-05-08 11:46:38

by Tang Bin

Subject: [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()

Delete unused initialized value, because 'retval' will be assigined
by the function mv_ehci_enable().

Signed-off-by: Zhang Shengju <[email protected]>
Signed-off-by: Tang Bin <[email protected]>
---
drivers/usb/host/ehci-mv.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index bd4f6ef53..1c079953e 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
struct ehci_hcd *ehci;
struct ehci_hcd_mv *ehci_mv;
struct resource *r;
- int retval = -ENODEV;
+ int retval;
u32 offset;

if (usb_disabled())
@@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev)
goto err_put_hcd;
}

-
-
r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ehci_mv->base = devm_ioremap_resource(&pdev->dev, r);
if (IS_ERR(ehci_mv->base)) {
--
2.20.1.windows.1

2020-05-08 13:51:36

by Alan Stern

Subject: Re: [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()

On Fri, 8 May 2020, Tang Bin wrote:

> Delete unused initialized value, because 'retval' will be assigined
> by the function mv_ehci_enable().

This should also mention the extra blank line that the patch removes.

Alan Stern

> Signed-off-by: Zhang Shengju <[email protected]>
> Signed-off-by: Tang Bin <[email protected]>
> ---
> drivers/usb/host/ehci-mv.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
> index bd4f6ef53..1c079953e 100644
> --- a/drivers/usb/host/ehci-mv.c
> +++ b/drivers/usb/host/ehci-mv.c
> @@ -108,7 +108,7 @@ static int mv_ehci_probe(struct platform_device *pdev)
> struct ehci_hcd *ehci;
> struct ehci_hcd_mv *ehci_mv;
> struct resource *r;
> - int retval = -ENODEV;
> + int retval;
> u32 offset;
>
> if (usb_disabled())
> @@ -142,8 +142,6 @@ static int mv_ehci_probe(struct platform_device *pdev)
> goto err_put_hcd;
> }
>
> -
> -
> r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> ehci_mv->base = devm_ioremap_resource(&pdev->dev, r);
> if (IS_ERR(ehci_mv->base)) {
>

2020-05-08 14:08:28

by Tang Bin

Subject: Re: [PATCH] USB: EHCI: ehci-mv: Fix unused assignment in mv_ehci_probe()

On 2020/5/8 21:49, Alan Stern wrote:
> On Fri, 8 May 2020, Tang Bin wrote:
>
>> Delete unused initialized value, because 'retval' will be assigined
>> by the function mv_ehci_enable().
> This should also mention the extra blank line that the patch removes.

Sorry, my mistake, I'll send v2 for you.

Thanks,

Tang Bin

>