2021-10-22 06:18:23

by Lukas Bulwahn

Subject: [PATCH] riscv: do not select non-existing config ANON_INODES

Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects
the config ANON_INODES in config KVM, but the config ANON_INODES is removed
since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.

Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:

ANON_INODES
Referencing files: arch/riscv/kvm/Kconfig

Remove selecting the non-existing config ANON_INODES.

Signed-off-by: Lukas Bulwahn <[email protected]>
---
arch/riscv/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index a712bb910cda..f5a342fa1b1d 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -22,7 +22,6 @@ config KVM
depends on RISCV_SBI && MMU
select MMU_NOTIFIER
select PREEMPT_NOTIFIERS
- select ANON_INODES
select KVM_MMIO
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select HAVE_KVM_VCPU_ASYNC_IOCTL
--
2.26.2

2021-10-22 09:56:18

by Paolo Bonzini

Subject: Re: [PATCH] riscv: do not select non-existing config ANON_INODES

On 22/10/21 08:15, Lukas Bulwahn wrote:
> Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects
> the config ANON_INODES in config KVM, but the config ANON_INODES is removed
> since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.
>
> Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:
>
> ANON_INODES
> Referencing files: arch/riscv/kvm/Kconfig
>
> Remove selecting the non-existing config ANON_INODES.
>
> Signed-off-by: Lukas Bulwahn <[email protected]>
> ---
> arch/riscv/kvm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
> index a712bb910cda..f5a342fa1b1d 100644
> --- a/arch/riscv/kvm/Kconfig
> +++ b/arch/riscv/kvm/Kconfig
> @@ -22,7 +22,6 @@ config KVM
> depends on RISCV_SBI && MMU
> select MMU_NOTIFIER
> select PREEMPT_NOTIFIERS
> - select ANON_INODES
> select KVM_MMIO
> select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> select HAVE_KVM_VCPU_ASYNC_IOCTL
>

Queued, thanks.

Paolo

2021-10-22 11:58:31

by Anup Patel

Subject: Re: [PATCH] riscv: do not select non-existing config ANON_INODES

On Fri, Oct 22, 2021 at 3:24 PM Paolo Bonzini <[email protected]> wrote:
>
> On 22/10/21 08:15, Lukas Bulwahn wrote:
> > Commit 99cdc6c18c2d ("RISC-V: Add initial skeletal KVM support") selects
> > the config ANON_INODES in config KVM, but the config ANON_INODES is removed
> > since commit 5dd50aaeb185 ("Make anon_inodes unconditional") in 2018.
> >
> > Hence, ./scripts/checkkconfigsymbols.py warns on non-existing symbols:
> >
> > ANON_INODES
> > Referencing files: arch/riscv/kvm/Kconfig
> >
> > Remove selecting the non-existing config ANON_INODES.
> >
> > Signed-off-by: Lukas Bulwahn <[email protected]>
> > ---
> > arch/riscv/kvm/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
> > index a712bb910cda..f5a342fa1b1d 100644
> > --- a/arch/riscv/kvm/Kconfig
> > +++ b/arch/riscv/kvm/Kconfig
> > @@ -22,7 +22,6 @@ config KVM
> > depends on RISCV_SBI && MMU
> > select MMU_NOTIFIER
> > select PREEMPT_NOTIFIERS
> > - select ANON_INODES
> > select KVM_MMIO
> > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > select HAVE_KVM_VCPU_ASYNC_IOCTL
> >
>
> Queued, thanks.

Thanks Paolo for applying this directly.

Regards,
Anup

>
> Paolo
>