2020-07-09 04:40:08

by Guo Ren

Subject: [PATCH] riscv: Enable ELF-ASLR for riscv

From: Guo Ren <[email protected]>

Let riscv enable randomizes the stack, heap and binary images of
ELF binaries. Seems it's ok at all after qemu & chip test and
there is no founded side effect.

So just simply select ARCH_HAS_ELF_RANDOMIZE :)

Signed-off-by: Guo Ren <[email protected]>
Cc: Palmer Dabbelt <[email protected]>
Cc: Paul Walmsley <[email protected]>
Cc: Zong Li <[email protected]>
Cc: Greentime Hu <[email protected]>
---
arch/riscv/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 91bfc6c..eed6647 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -20,6 +20,7 @@ config RISCV
select ARCH_HAS_GIGANTIC_PAGE
select ARCH_HAS_MMIOWB
select ARCH_HAS_PTE_SPECIAL
+ select ARCH_HAS_ELF_RANDOMIZE
select ARCH_HAS_SET_DIRECT_MAP
select ARCH_HAS_SET_MEMORY
select ARCH_HAS_STRICT_KERNEL_RWX if MMU
--
2.7.4

2020-07-09 05:33:22

by Alexandre Ghiti

Subject: Re: [PATCH] riscv: Enable ELF-ASLR for riscv

Hi Guo,

Le 7/9/20 ? 12:38 AM, [email protected] a ?crit?:
> From: Guo Ren <[email protected]>
>
> Let riscv enable randomizes the stack, heap and binary images of
> ELF binaries. Seems it's ok at all after qemu & chip test and
> there is no founded side effect.
>
> So just simply select ARCH_HAS_ELF_RANDOMIZE :)
>
> Signed-off-by: Guo Ren <[email protected]>
> Cc: Palmer Dabbelt <[email protected]>
> Cc: Paul Walmsley <[email protected]>
> Cc: Zong Li <[email protected]>
> Cc: Greentime Hu <[email protected]>
> ---
> arch/riscv/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 91bfc6c..eed6647 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -20,6 +20,7 @@ config RISCV
> select ARCH_HAS_GIGANTIC_PAGE
> select ARCH_HAS_MMIOWB
> select ARCH_HAS_PTE_SPECIAL
> + select ARCH_HAS_ELF_RANDOMIZE
> select ARCH_HAS_SET_DIRECT_MAP
> select ARCH_HAS_SET_MEMORY
> select ARCH_HAS_STRICT_KERNEL_RWX if MMU
>

Actually it is already the case: ARCH_HAS_ELF_RANDOMIZE is already
selected by ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT.

Thanks,

Alex

2020-07-09 08:00:43

by Guo Ren

Subject: Re: [PATCH] riscv: Enable ELF-ASLR for riscv

On Thu, Jul 9, 2020 at 1:32 PM Alex Ghiti <[email protected]> wrote:
>
> Hi Guo,
>
> Le 7/9/20 à 12:38 AM, [email protected] a écrit :
> > From: Guo Ren <[email protected]>
> >
> > Let riscv enable randomizes the stack, heap and binary images of
> > ELF binaries. Seems it's ok at all after qemu & chip test and
> > there is no founded side effect.
> >
> > So just simply select ARCH_HAS_ELF_RANDOMIZE :)
> >
> > Signed-off-by: Guo Ren <[email protected]>
> > Cc: Palmer Dabbelt <[email protected]>
> > Cc: Paul Walmsley <[email protected]>
> > Cc: Zong Li <[email protected]>
> > Cc: Greentime Hu <[email protected]>
> > ---
> > arch/riscv/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> > index 91bfc6c..eed6647 100644
> > --- a/arch/riscv/Kconfig
> > +++ b/arch/riscv/Kconfig
> > @@ -20,6 +20,7 @@ config RISCV
> > select ARCH_HAS_GIGANTIC_PAGE
> > select ARCH_HAS_MMIOWB
> > select ARCH_HAS_PTE_SPECIAL
> > + select ARCH_HAS_ELF_RANDOMIZE
> > select ARCH_HAS_SET_DIRECT_MAP
> > select ARCH_HAS_SET_MEMORY
> > select ARCH_HAS_STRICT_KERNEL_RWX if MMU
> >
>
> Actually it is already the case: ARCH_HAS_ELF_RANDOMIZE is already
> selected by ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT.
Oops :P, Thx for correcting, abandon the patch.

--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/