2017-07-05 10:47:05

by Arvind Yadav

Subject: [PATCH] input: keyboard: constify attribute_group structures.

attribute_groups are not supposed to change at runtime. All functions
working with attribute_groups provided by <linux/sysfs.h> work with const
attribute_group. So mark the non-const structs as const.

File size before:
text data bss dec hex filename
5693 464 0 6157 180d drivers/input/keyboard/gpio_keys.o

File size After adding 'const':
text data bss dec hex filename
5749 400 0 6149 1805 drivers/input/keyboard/gpio_keys.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/input/keyboard/gpio_keys.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
index da3d362..55cf8aa 100644
--- a/drivers/input/keyboard/gpio_keys.c
+++ b/drivers/input/keyboard/gpio_keys.c
@@ -352,7 +352,7 @@ static DEVICE_ATTR(disabled_switches, S_IWUSR | S_IRUGO,
NULL,
};

-static struct attribute_group gpio_keys_attr_group = {
+static const struct attribute_group gpio_keys_attr_group = {
.attrs = gpio_keys_attrs,
};

--
1.9.1

2017-07-31 13:42:04

by Linus Walleij

Subject: Re: [PATCH] input: keyboard: constify attribute_group structures.

On Wed, Jul 5, 2017 at 12:46 PM, Arvind Yadav <[email protected]> wrote:

> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 5693 464 0 6157 180d drivers/input/keyboard/gpio_keys.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 5749 400 0 6149 1805 drivers/input/keyboard/gpio_keys.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Acked-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij