Richtek's rt5033-led has pin configurations similar to sgm3140.
Add it to the compatible list.
Richtek's rt5033-led has pin configurations similar to sgm3140.
Add it to the compatible list.
Signed-off-by: Raymond Hackley <[email protected]>
---
drivers/leds/flash/leds-sgm3140.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/leds/flash/leds-sgm3140.c b/drivers/leds/flash/leds-sgm3140.c
index d3a30ad94ac4..d3f50dca5136 100644
--- a/drivers/leds/flash/leds-sgm3140.c
+++ b/drivers/leds/flash/leds-sgm3140.c
@@ -291,6 +291,7 @@ static int sgm3140_remove(struct platform_device *pdev)
static const struct of_device_id sgm3140_dt_match[] = {
{ .compatible = "ocs,ocp8110" },
+ { .compatible = "richtek,rt5033-led" },
{ .compatible = "sgmicro,sgm3140" },
{ /* sentinel */ }
};
--
2.30.2
Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
camera flash LEDs.
Signed-off-by: Raymond Hackley <[email protected]>
---
Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
index 4d2ffe5fcfc7..37d2a93780ab 100644
--- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
+++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
@@ -20,6 +20,7 @@ properties:
compatible:
enum:
- ocs,ocp8110
+ - richtek,rt5033-led
- sgmicro,sgm3140
enable-gpios:
--
2.30.2
Hi Raymond,
On Freitag, 2. Juni 2023 15:36:16 CEST Raymond Hackley wrote:
> Richtek's rt5033-led has pin configurations similar to sgm3140.
> Add it to the compatible list.
please fix your email setup so that patches also sent to public mailing lists
don't get *encrypted*. This is completely pointless and just makes everything
more difficult.
Regards
Luca
On 02/06/2023 15:38, Raymond Hackley wrote:
> Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> camera flash LEDs.
What are the similarities? Same register interface? Same pins? It's not
obvious and your commit should clear explain this. It will be also
justification why you did not make devices compatible.
Best regards,
Krzysztof
I've not seen this because Protonmail has encoded your mail.
On Fri, 02 Jun 2023, Raymond Hackley wrote:
> Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> camera flash LEDs.
>
> Signed-off-by: Raymond Hackley <[email protected]>
> ---
> Documentation/devicetree/bindings/leds/leds-sgm3140.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> index 4d2ffe5fcfc7..37d2a93780ab 100644
> --- a/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-sgm3140.yaml
> @@ -20,6 +20,7 @@ properties:
> compatible:
> enum:
> - ocs,ocp8110
> + - richtek,rt5033-led
> - sgmicro,sgm3140
>
> enable-gpios:
> --
> 2.30.2
>
>
--
Lee Jones [李琼斯]
Hi Krzysztof,
On Sunday, June 4th, 2023 at 10:43 AM, Krzysztof Kozlowski <[email protected]> wrote:
> On 02/06/2023 15:38, Raymond Hackley wrote:
>
> > Add devicetree binding for Richtek RT5033 Flash LED charge pump used for
> > camera flash LEDs.
>
>
> What are the similarities? Same register interface? Same pins? It's not
> obvious and your commit should clear explain this. It will be also
> justification why you did not make devices compatible.
>
There is a similar way to control with 2 GPIO pins, strobe and enable,
which is not described well in this patch set.
Regards,
Raymond