2019-05-14 07:28:42

by Sabyasachi Gupta

[permalink] [raw]
Subject: [PATCH] drm/msm/dpu: Remove duplicate header

Remove dpu_kms.h which is included more than once

Signed-off-by: Sabyasachi Gupta <[email protected]>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
index dbe48e00..d692dee 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
@@ -16,7 +16,6 @@
#include "dpu_hw_lm.h"
#include "dpu_hw_mdss.h"
#include "dpu_dbg.h"
-#include "dpu_kms.h"

#define LM_OP_MODE 0x00
#define LM_OUT_SIZE 0x04
--
2.7.4


2019-05-15 18:38:46

by Sean Paul

[permalink] [raw]
Subject: Re: [PATCH] drm/msm/dpu: Remove duplicate header

On Tue, May 14, 2019 at 12:57:28PM +0530, Sabyasachi Gupta wrote:
> Remove dpu_kms.h which is included more than once
>
> Signed-off-by: Sabyasachi Gupta <[email protected]>

Thanks for your patch, I've applied it to drm-misc-next-fixes.

Note for next time: The patch didn't apply cleanly since dpu_dbg.h has been
removed upstream. In future please make sure your patches apply cleanly and
at least build against upstream.

Thanks again!

Sean

> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
> index dbe48e00..d692dee 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c
> @@ -16,7 +16,6 @@
> #include "dpu_hw_lm.h"
> #include "dpu_hw_mdss.h"
> #include "dpu_dbg.h"
> -#include "dpu_kms.h"
>
> #define LM_OP_MODE 0x00
> #define LM_OUT_SIZE 0x04
> --
> 2.7.4
>

--
Sean Paul, Software Engineer, Google / Chromium OS