2024-04-09 12:29:01

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH 1/9] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT

On Tue, Apr 09, 2024 at 01:23:36AM +0000, Liao Chang wrote:
> From: Mark Brown <[email protected]>
>
> Encodings are provided for ALLINT which allow setting of ALLINT.ALLINT
> using an immediate rather than requiring that a register be loaded with
> the value to write. Since these don't currently fit within the scheme we
> have for sysreg generation add manual encodings like we currently do for
> other similar registers such as SVCR.
>
> Since it is required that these immediate versions be encoded with xzr
> as the source register provide asm wrapper which ensure this is the
> case.
>
> Signed-off-by: Mark Brown <[email protected]>
> ---
> arch/arm64/include/asm/nmi.h | 27 +++++++++++++++++++++++++++

You've not provided a Signed-off-by for this so people can't do anything
with it, please see Documentation/process/submitting-patches.rst for
details on what this is and why it's important.


Attachments:
(No filename) (931.00 B)
signature.asc (499.00 B)
Download all attachments

2024-04-10 02:06:37

by Liao, Chang

[permalink] [raw]
Subject: Re: [PATCH 1/9] arm64/sysreg: Add definitions for immediate versions of MSR ALLINT

Mark,

在 2024/4/9 20:28, Mark Brown 写道:
> On Tue, Apr 09, 2024 at 01:23:36AM +0000, Liao Chang wrote:
>> From: Mark Brown <[email protected]>
>>
>> Encodings are provided for ALLINT which allow setting of ALLINT.ALLINT
>> using an immediate rather than requiring that a register be loaded with
>> the value to write. Since these don't currently fit within the scheme we
>> have for sysreg generation add manual encodings like we currently do for
>> other similar registers such as SVCR.
>>
>> Since it is required that these immediate versions be encoded with xzr
>> as the source register provide asm wrapper which ensure this is the
>> case.
>>
>> Signed-off-by: Mark Brown <[email protected]>
>> ---
>> arch/arm64/include/asm/nmi.h | 27 +++++++++++++++++++++++++++
>
> You've not provided a Signed-off-by for this so people can't do anything
> with it, please see Documentation/process/submitting-patches.rst for
> details on what this is and why it's important.

Acked, thanks for the heads-up. I'll add Signed-off-by tags to the relevant
patches in the next revision. This includes patches from your FEAT_NMI patchset
and Jinjie's contribution.

--
BR
Liao, Chang