2020-03-04 12:03:32

by Veerabhadrarao Badiganti

[permalink] [raw]
Subject: [PATCH] mmc: cqhci: Update cqhci memory ioresource name

Update cqhci memory ioresource name from cqhci_mem to cqhci since
suffix _mem is redundant.

Signed-off-by: Veerabhadrarao Badiganti <[email protected]>
---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/
---
drivers/mmc/host/cqhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
index e2ea2c4..e24b8ff 100644
--- a/drivers/mmc/host/cqhci.c
+++ b/drivers/mmc/host/cqhci.c
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)

/* check and setup CMDQ interface */
cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
- "cqhci_mem");
+ "cqhci");
if (!cqhci_memres) {
dev_dbg(&pdev->dev, "CMDQ not supported\n");
return ERR_PTR(-EINVAL);
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project


2020-03-04 12:25:08

by Adrian Hunter

[permalink] [raw]
Subject: Re: [PATCH] mmc: cqhci: Update cqhci memory ioresource name

On 4/03/20 2:00 pm, Veerabhadrarao Badiganti wrote:
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.

Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(),
right? So no one else could be using "cqhci_mem"? Some more explanation is
needed here.

>
> Signed-off-by: Veerabhadrarao Badiganti <[email protected]>
> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>
> /* check and setup CMDQ interface */
> cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> - "cqhci_mem");
> + "cqhci");
> if (!cqhci_memres) {
> dev_dbg(&pdev->dev, "CMDQ not supported\n");
> return ERR_PTR(-EINVAL);
>

2020-03-04 13:13:32

by Veerabhadrarao Badiganti

[permalink] [raw]
Subject: Re: [PATCH] mmc: cqhci: Update cqhci memory ioresource name


On 3/4/2020 5:53 PM, Adrian Hunter wrote:
> On 4/03/20 2:00 pm, Veerabhadrarao Badiganti wrote:
>> Update cqhci memory ioresource name from cqhci_mem to cqhci since
>> suffix _mem is redundant.
> Which is OK only because sdhci-msm is the only caller of cqhci_pltfm_init(),
> right? So no one else could be using "cqhci_mem"? Some more explanation is
> needed here.

Right, only qcom cqhci solution is making use of it.

I did a grep in dt and find no other vendor is using it.

Sure. Will update commit text.

>> Signed-off-by: Veerabhadrarao Badiganti <[email protected]>
>> ---
>> Corresponding binding change:
>> https://lore.kernel.org/linux-arm-msm/[email protected]/
>> ---
>> drivers/mmc/host/cqhci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
>> index e2ea2c4..e24b8ff 100644
>> --- a/drivers/mmc/host/cqhci.c
>> +++ b/drivers/mmc/host/cqhci.c
>> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>>
>> /* check and setup CMDQ interface */
>> cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
>> - "cqhci_mem");
>> + "cqhci");
>> if (!cqhci_memres) {
>> dev_dbg(&pdev->dev, "CMDQ not supported\n");
>> return ERR_PTR(-EINVAL);
>>

2020-03-04 13:26:13

by Veerabhadrarao Badiganti

[permalink] [raw]
Subject: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name

Update cqhci memory ioresource name from cqhci_mem to cqhci since
suffix _mem is redundant.

Only sdhci-msm driver is making use of this resource as of now.
No other vendor's driver is using it. So this update shouldn't affect
any other vendor's cqhci functionality.

Signed-off-by: Veerabhadrarao Badiganti <[email protected]>
---
Corresponding binding change:
https://lore.kernel.org/linux-arm-msm/[email protected]/

Changes sicne V1:
- Updated commit text expalining this change affects *only*
qcom cqhci functionality.

---
drivers/mmc/host/cqhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
index e2ea2c4..e24b8ff 100644
--- a/drivers/mmc/host/cqhci.c
+++ b/drivers/mmc/host/cqhci.c
@@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)

/* check and setup CMDQ interface */
cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
- "cqhci_mem");
+ "cqhci");
if (!cqhci_memres) {
dev_dbg(&pdev->dev, "CMDQ not supported\n");
return ERR_PTR(-EINVAL);
--
Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

2020-03-04 14:04:36

by Adrian Hunter

[permalink] [raw]
Subject: Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name

On 4/03/20 3:25 pm, Veerabhadrarao Badiganti wrote:
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
>
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
>
> Signed-off-by: Veerabhadrarao Badiganti <[email protected]>

Acked-by: Adrian Hunter <[email protected]>

> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Changes sicne V1:
> - Updated commit text expalining this change affects *only*
> qcom cqhci functionality.
>
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>
> /* check and setup CMDQ interface */
> cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> - "cqhci_mem");
> + "cqhci");
> if (!cqhci_memres) {
> dev_dbg(&pdev->dev, "CMDQ not supported\n");
> return ERR_PTR(-EINVAL);
>

2020-03-04 16:01:09

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name

Hi,

On Wed, Mar 4, 2020 at 5:25 AM Veerabhadrarao Badiganti
<[email protected]> wrote:
>
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
>
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
>
> Signed-off-by: Veerabhadrarao Badiganti <[email protected]>
> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Changes sicne V1:
> - Updated commit text expalining this change affects *only*
> qcom cqhci functionality.
>
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

...now I guess the last thing is the dts change...

Reviewed-by: Douglas Anderson <[email protected]>

2020-03-09 18:32:26

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name

On Wed 04 Mar 05:25 PST 2020, Veerabhadrarao Badiganti wrote:

> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
>
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
>
> Signed-off-by: Veerabhadrarao Badiganti <[email protected]>

I do favor using names without the "_mem" suffix and it seems like the
existing code only acquire the first two regions by index. So this
should be fine.

Acked-by: Bjorn Andersson <[email protected]>


But I do expect to see some patches fixing up the 8 dts files that now
has invalid reg-names.

Regards,
Bjorn

> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Changes sicne V1:
> - Updated commit text expalining this change affects *only*
> qcom cqhci functionality.
>
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>
> /* check and setup CMDQ interface */
> cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> - "cqhci_mem");
> + "cqhci");
> if (!cqhci_memres) {
> dev_dbg(&pdev->dev, "CMDQ not supported\n");
> return ERR_PTR(-EINVAL);
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project

2020-03-11 15:36:34

by Ulf Hansson

[permalink] [raw]
Subject: Re: [PATCH V2] mmc: cqhci: Update cqhci memory ioresource name

On Wed, 4 Mar 2020 at 14:25, Veerabhadrarao Badiganti
<[email protected]> wrote:
>
> Update cqhci memory ioresource name from cqhci_mem to cqhci since
> suffix _mem is redundant.
>
> Only sdhci-msm driver is making use of this resource as of now.
> No other vendor's driver is using it. So this update shouldn't affect
> any other vendor's cqhci functionality.
>
> Signed-off-by: Veerabhadrarao Badiganti <[email protected]>

Applied for next, thanks!

Kind regards
Uffe


> ---
> Corresponding binding change:
> https://lore.kernel.org/linux-arm-msm/[email protected]/
>
> Changes sicne V1:
> - Updated commit text expalining this change affects *only*
> qcom cqhci functionality.
>
> ---
> drivers/mmc/host/cqhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci.c b/drivers/mmc/host/cqhci.c
> index e2ea2c4..e24b8ff 100644
> --- a/drivers/mmc/host/cqhci.c
> +++ b/drivers/mmc/host/cqhci.c
> @@ -1077,7 +1077,7 @@ struct cqhci_host *cqhci_pltfm_init(struct platform_device *pdev)
>
> /* check and setup CMDQ interface */
> cqhci_memres = platform_get_resource_byname(pdev, IORESOURCE_MEM,
> - "cqhci_mem");
> + "cqhci");
> if (!cqhci_memres) {
> dev_dbg(&pdev->dev, "CMDQ not supported\n");
> return ERR_PTR(-EINVAL);
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc., is a member of Code Aurora Forum, a Linux Foundation Collaborative Project