2022-09-02 07:55:00

by CGEL

Subject: [PATCH linux-next] btrfs: Remove the unneeded result variable

From: zhang songyi <[email protected]>

Return the sysfs_emit() directly instead of storing it in another
redundant variable.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: zhang songyi <[email protected]>
---
fs/btrfs/sysfs.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 41f191682ad1..6268dade57d7 100644
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -839,11 +839,8 @@ static ssize_t btrfs_sinfo_bg_reclaim_threshold_show(struct kobject *kobj,
char *buf)
{
struct btrfs_space_info *space_info = to_space_info(kobj);
- ssize_t ret;
-
- ret = sysfs_emit(buf, "%d\n", READ_ONCE(space_info->bg_reclaim_threshold));

- return ret;
+ return sysfs_emit(buf, "%d\n", READ_ONCE(space_info->bg_reclaim_threshold));
}

static ssize_t btrfs_sinfo_bg_reclaim_threshold_store(struct kobject *kobj,
@@ -1205,11 +1202,8 @@ static ssize_t btrfs_bg_reclaim_threshold_show(struct kobject *kobj,
char *buf)
{
struct btrfs_fs_info *fs_info = to_fs_info(kobj);
- ssize_t ret;
-
- ret = sysfs_emit(buf, "%d\n", READ_ONCE(fs_info->bg_reclaim_threshold));

- return ret;
+ return sysfs_emit(buf, "%d\n", READ_ONCE(fs_info->bg_reclaim_threshold));
}

static ssize_t btrfs_bg_reclaim_threshold_store(struct kobject *kobj,
--
2.25.1

2022-09-02 12:52:34

by David Sterba

Subject: Re: [PATCH linux-next] btrfs: Remove the unneeded result variable

On Fri, Sep 02, 2022 at 07:48:10AM +0000, [email protected] wrote:
> From: zhang songyi <[email protected]>
>
> Return the sysfs_emit() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: zhang songyi <[email protected]>

There's another patch doing a similar cleanup in btrfs_load_inode_props,
can you please resend so it's all done in one patch? I did not want to
apply a single fix but now that there are a few more instances of the
pattern it makes slightly more sense to apply it. Thanks.

https://lore.kernel.org/linux-btrfs/[email protected]/

2022-09-05 04:55:32

by Anand Jain

Subject: Re: [PATCH linux-next] btrfs: Remove the unneeded result variable

On 02/09/2022 15:48, [email protected] wrote:
> From: zhang songyi <[email protected]>
>
> Return the sysfs_emit() directly instead of storing it in another
> redundant variable.
>
> Reported-by: Zeal Robot <[email protected]>
> Signed-off-by: zhang songyi <[email protected]>

Reviewed-by: Anand Jain <[email protected]>