2007-06-26 12:34:55

by Trilok Soni

[permalink] [raw]
Subject: [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.

--
--Trilok Soni

Attachments:
(No filename) (18.00 B)
 0002-OMAP-Add-TI-OMAP1610-accelerator-entry.patch (1.00 kB)
 Download all attachments

2007-06-26 16:52:17

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.

Your patch ordering is bad.
Patch 1 uses the symbol: FB_ACCEL_OMAP1610
but it is defined by patch 2.

Please reorder patches so the module compiles for each
and every patch being applied.

In this way you do not break git bisect for example.

Sam

2007-06-27 11:30:57

by Trilok Soni

[permalink] [raw]
Subject: Re: [PATCH 02/17] OMAP: Add TI OMAP1610 accelerator entry.

On 6/26/07, Sam Ravnborg <[email protected]> wrote:
> Your patch ordering is bad.
> Patch 1 uses the symbol: FB_ACCEL_OMAP1610
> but it is defined by patch 2.
>
> Please reorder patches so the module compiles for each
> and every patch being applied.
>
> In this way you do not break git bisect for example.
>

Yes, in this case I will merge 1st and 2nd patch.

--
--Trilok Soni