2007-06-26 12:34:23

by Trilok Soni

[permalink] [raw]
Subject: [PATCH 01/17] OMAP: Add TI OMAP framebuffer driver

--
--Trilok Soni

Attachments:
(No filename) (18.00 B)
 0001-OMAP-Add-TI-OMAP-framebuffer-driver.patch (53.27 kB)
 Download all attachments

2007-06-26 16:49:16

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH 01/17] OMAP: Add TI OMAP framebuffer driver

diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile
new file mode 100644
index 0000000..5aa7175
--- /dev/null
+++ b/drivers/video/omap/Makefile
@@ -0,0 +1,10 @@
+#
+# Makefile for the new OMAP framebuffer device driver
+#
+
+obj-$(CONFIG_FB_OMAP) += omapfb.o
+
+objs-yy := omapfb_main.o
+
+omapfb-objs := $(objs-yy)
+

This looks strangs.
Please use:
obj-$(CONFIG_FB_OMAP) += omapfb.o

omapfb-y := omapfb_main.o

Or even better rename your .c file to omapfb.c then
you only need to use:
obj-$(CONFIG_FB_OMAP) += omapfb.o

Sam

2007-06-27 08:44:19

by Trilok Soni

[permalink] [raw]
Subject: Re: [PATCH 01/17] OMAP: Add TI OMAP framebuffer driver

Hi Sam,

On 6/26/07, Sam Ravnborg <[email protected]> wrote:
> diff --git a/drivers/video/omap/Makefile b/drivers/video/omap/Makefile
> new file mode 100644
> index 0000000..5aa7175
> --- /dev/null
> +++ b/drivers/video/omap/Makefile
> @@ -0,0 +1,10 @@
> +#
> +# Makefile for the new OMAP framebuffer device driver
> +#
> +
> +obj-$(CONFIG_FB_OMAP) += omapfb.o
> +
> +objs-yy := omapfb_main.o
> +
> +omapfb-objs := $(objs-yy)
> +
>
> This looks strangs.
> Please use:
> obj-$(CONFIG_FB_OMAP) += omapfb.o
>
> omapfb-y := omapfb_main.o
>
> Or even better rename your .c file to omapfb.c then
> you only need to use:
> obj-$(CONFIG_FB_OMAP) += omapfb.o
>

Thanx for the review. I will incorporate your suggestions into the
next update of fb patches.

--
--Trilok Soni