2019-06-07 09:04:03

by Bartosz Golaszewski

[permalink] [raw]
Subject: [PATCH] ARM: davinci: da850-evm: call regulator_has_full_constraints()

From: Bartosz Golaszewski <[email protected]>

The BB expander at 0x21 i2c bus 1 fails to probe on da850-evm because
the board doesn't set has_full_constraints to true in the regulator
API.

Call regulator_has_full_constraints() at the end of board registration
just like we do in da850-lcdk and da830-evm.

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
arch/arm/mach-davinci/board-da850-evm.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm/mach-davinci/board-da850-evm.c b/arch/arm/mach-davinci/board-da850-evm.c
index 4ee65a8a3b80..31ae3be5741d 100644
--- a/arch/arm/mach-davinci/board-da850-evm.c
+++ b/arch/arm/mach-davinci/board-da850-evm.c
@@ -1480,6 +1480,8 @@ static __init void da850_evm_init(void)
if (ret)
pr_warn("%s: dsp/rproc registration failed: %d\n",
__func__, ret);
+
+ regulator_has_full_constraints();
}

#ifdef CONFIG_SERIAL_8250_CONSOLE
--
2.21.0


2019-06-08 14:08:50

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] ARM: davinci: da850-evm: call regulator_has_full_constraints()

On Fri, Jun 7, 2019 at 11:02 AM Bartosz Golaszewski <[email protected]> wrote:

> From: Bartosz Golaszewski <[email protected]>
>
> The BB expander at 0x21 i2c bus 1 fails to probe on da850-evm because
> the board doesn't set has_full_constraints to true in the regulator
> API.
>
> Call regulator_has_full_constraints() at the end of board registration
> just like we do in da850-lcdk and da830-evm.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

I assume Sekhar will queue this and the LED patch?

Yours,
Linus Walleij

2019-06-14 10:49:42

by Sekhar Nori

[permalink] [raw]
Subject: Re: [PATCH] ARM: davinci: da850-evm: call regulator_has_full_constraints()

On 08/06/19 7:37 PM, Linus Walleij wrote:
> On Fri, Jun 7, 2019 at 11:02 AM Bartosz Golaszewski <[email protected]> wrote:
>
>> From: Bartosz Golaszewski <[email protected]>
>>
>> The BB expander at 0x21 i2c bus 1 fails to probe on da850-evm because
>> the board doesn't set has_full_constraints to true in the regulator
>> API.
>>
>> Call regulator_has_full_constraints() at the end of board registration
>> just like we do in da850-lcdk and da830-evm.
>>
>> Signed-off-by: Bartosz Golaszewski <[email protected]>
>
> Reviewed-by: Linus Walleij <[email protected]>
>
> I assume Sekhar will queue this and the LED patch?

Yes, will do. Added this to fixes for v5.2

Thanks,
Sekhar