2020-09-26 06:57:45

by Dmitry Vyukov

[permalink] [raw]
Subject: Re: KMSAN: uninit-value in rt2500usb_probe_hw

On Sat, Sep 26, 2020 at 5:25 AM syzbot
<[email protected]> wrote:
>
> Hello,
>
> syzbot has tested the proposed patch and the reproducer did not trigger any issue:
>
> Reported-and-tested-by: [email protected]
>
> Tested on:
>
> commit: c5a13b33 kmsan: clang-format core
> git tree: https://github.com/google/kmsan.git master
> kernel config: https://syzkaller.appspot.com/x/.config?x=41fca8ac7f9e770a
> dashboard link: https://syzkaller.appspot.com/bug?extid=35c80b2190255a410f66
> compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
>
> Note: testing is done by a robot and is best-effort only.

Hi Anant,

I see you are testing lots of USB bugs. USB subsystem is currently
broken, testing of any USB bugs will give false "no crash" results,
see:
https://lore.kernel.org/linux-kernel-mentees/CACT4Y+YmbmrH9gCCnCzP-FYa-dKxx9qhKZ+RQxi1f-+Hoj1SUg@mail.gmail.com/


2020-09-26 07:00:46

by Greg KH

[permalink] [raw]
Subject: Re: [Linux-kernel-mentees] KMSAN: uninit-value in rt2500usb_probe_hw

On Sat, Sep 26, 2020 at 08:53:07AM +0200, Dmitry Vyukov via Linux-kernel-mentees wrote:
> On Sat, Sep 26, 2020 at 5:25 AM syzbot
> <[email protected]> wrote:
> >
> > Hello,
> >
> > syzbot has tested the proposed patch and the reproducer did not trigger any issue:
> >
> > Reported-and-tested-by: [email protected]
> >
> > Tested on:
> >
> > commit: c5a13b33 kmsan: clang-format core
> > git tree: https://github.com/google/kmsan.git master
> > kernel config: https://syzkaller.appspot.com/x/.config?x=41fca8ac7f9e770a
> > dashboard link: https://syzkaller.appspot.com/bug?extid=35c80b2190255a410f66
> > compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
> >
> > Note: testing is done by a robot and is best-effort only.
>
> Hi Anant,
>
> I see you are testing lots of USB bugs. USB subsystem is currently
> broken, testing of any USB bugs will give false "no crash" results,
> see:
> https://lore.kernel.org/linux-kernel-mentees/CACT4Y+YmbmrH9gCCnCzP-FYa-dKxx9qhKZ+RQxi1f-+Hoj1SUg@mail.gmail.com/

Fixes for this USB problem are in my tree now and should show up in
linux-next on Monday.

thanks,

greg k-h

2020-09-26 07:03:06

by Anant Thazhemadam

[permalink] [raw]
Subject: Re: KMSAN: uninit-value in rt2500usb_probe_hw


On 26/09/20 12:23 pm, Dmitry Vyukov wrote:
> On Sat, Sep 26, 2020 at 5:25 AM syzbot
> <[email protected]> wrote:
>> Hello,
>>
>> syzbot has tested the proposed patch and the reproducer did not trigger any issue:
>>
>> Reported-and-tested-by: [email protected]
>>
>> Tested on:
>>
>> commit: c5a13b33 kmsan: clang-format core
>> git tree: https://github.com/google/kmsan.git master
>> kernel config: https://syzkaller.appspot.com/x/.config?x=41fca8ac7f9e770a
>> dashboard link: https://syzkaller.appspot.com/bug?extid=35c80b2190255a410f66
>> compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
>>
>> Note: testing is done by a robot and is best-effort only.
> Hi Anant,
>
> I see you are testing lots of USB bugs. USB subsystem is currently
> broken, testing of any USB bugs will give false "no crash" results,
> see:
> https://lore.kernel.org/linux-kernel-mentees/CACT4Y+YmbmrH9gCCnCzP-FYa-dKxx9qhKZ+RQxi1f-+Hoj1SUg@mail.gmail.com/

Oh, I see. Thank you for letting me know. I'll be sure to keep that in mind, until I hear
otherwise. :)

Thanks,
Anant

2020-09-30 16:01:33

by Anant Thazhemadam

[permalink] [raw]
Subject: Re: [Linux-kernel-mentees] KMSAN: uninit-value in rt2500usb_probe_hw


On 26/09/20 12:27 pm, Greg KH wrote:
> On Sat, Sep 26, 2020 at 08:53:07AM +0200, Dmitry Vyukov via Linux-kernel-mentees wrote:
>> On Sat, Sep 26, 2020 at 5:25 AM syzbot
>> <[email protected]> wrote:
>>> Hello,
>>>
>>> syzbot has tested the proposed patch and the reproducer did not trigger any issue:
>>>
>>> Reported-and-tested-by: [email protected]
>>>
>>> Tested on:
>>>
>>> commit: c5a13b33 kmsan: clang-format core
>>> git tree: https://github.com/google/kmsan.git master
>>> kernel config: https://syzkaller.appspot.com/x/.config?x=41fca8ac7f9e770a
>>> dashboard link: https://syzkaller.appspot.com/bug?extid=35c80b2190255a410f66
>>> compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
>>>
>>> Note: testing is done by a robot and is best-effort only.
>> Hi Anant,
>>
>> I see you are testing lots of USB bugs. USB subsystem is currently
>> broken, testing of any USB bugs will give false "no crash" results,
>> see:
>> https://lore.kernel.org/linux-kernel-mentees/CACT4Y+YmbmrH9gCCnCzP-FYa-dKxx9qhKZ+RQxi1f-+Hoj1SUg@mail.gmail.com/
> Fixes for this USB problem are in my tree now and should show up in
> linux-next on Monday.
>
> thanks,
>
> greg k-h

Is there any chance you could identify the commit that fixes this bug?
It would help us close the bug for good. :)

Thanks,
Anant

2020-09-30 16:18:43

by Dmitry Vyukov

[permalink] [raw]
Subject: Re: [Linux-kernel-mentees] KMSAN: uninit-value in rt2500usb_probe_hw

On Wed, Sep 30, 2020 at 5:57 PM Anant Thazhemadam
<[email protected]> wrote:
> On 26/09/20 12:27 pm, Greg KH wrote:
> > On Sat, Sep 26, 2020 at 08:53:07AM +0200, Dmitry Vyukov via Linux-kernel-mentees wrote:
> >> On Sat, Sep 26, 2020 at 5:25 AM syzbot
> >> <[email protected]> wrote:
> >>> Hello,
> >>>
> >>> syzbot has tested the proposed patch and the reproducer did not trigger any issue:
> >>>
> >>> Reported-and-tested-by: [email protected]
> >>>
> >>> Tested on:
> >>>
> >>> commit: c5a13b33 kmsan: clang-format core
> >>> git tree: https://github.com/google/kmsan.git master
> >>> kernel config: https://syzkaller.appspot.com/x/.config?x=41fca8ac7f9e770a
> >>> dashboard link: https://syzkaller.appspot.com/bug?extid=35c80b2190255a410f66
> >>> compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
> >>>
> >>> Note: testing is done by a robot and is best-effort only.
> >> Hi Anant,
> >>
> >> I see you are testing lots of USB bugs. USB subsystem is currently
> >> broken, testing of any USB bugs will give false "no crash" results,
> >> see:
> >> https://lore.kernel.org/linux-kernel-mentees/CACT4Y+YmbmrH9gCCnCzP-FYa-dKxx9qhKZ+RQxi1f-+Hoj1SUg@mail.gmail.com/
> > Fixes for this USB problem are in my tree now and should show up in
> > linux-next on Monday.
> >
> > thanks,
> >
> > greg k-h
>
> Is there any chance you could identify the commit that fixes this bug?
> It would help us close the bug for good. :)

I think Greg meant the fix for the general USB brokenness, not a fix
for this syzbot bug. This bug is not fixed to the best of syzbot
knowledge.

2020-09-30 16:23:23

by Anant Thazhemadam

[permalink] [raw]
Subject: Re: [Linux-kernel-mentees] KMSAN: uninit-value in rt2500usb_probe_hw


On 30/09/20 9:46 pm, Dmitry Vyukov wrote:
> On Wed, Sep 30, 2020 at 5:57 PM Anant Thazhemadam
> <[email protected]> wrote:
>> On 26/09/20 12:27 pm, Greg KH wrote:
>>> On Sat, Sep 26, 2020 at 08:53:07AM +0200, Dmitry Vyukov via Linux-kernel-mentees wrote:
>>>> On Sat, Sep 26, 2020 at 5:25 AM syzbot
>>>> <[email protected]> wrote:
>>>>> Hello,
>>>>>
>>>>> syzbot has tested the proposed patch and the reproducer did not trigger any issue:
>>>>>
>>>>> Reported-and-tested-by: [email protected]
>>>>>
>>>>> Tested on:
>>>>>
>>>>> commit: c5a13b33 kmsan: clang-format core
>>>>> git tree: https://github.com/google/kmsan.git master
>>>>> kernel config: https://syzkaller.appspot.com/x/.config?x=41fca8ac7f9e770a
>>>>> dashboard link: https://syzkaller.appspot.com/bug?extid=35c80b2190255a410f66
>>>>> compiler: clang version 10.0.0 (https://github.com/llvm/llvm-project/ c2443155a0fb245c8f17f2c1c72b6ea391e86e81)
>>>>>
>>>>> Note: testing is done by a robot and is best-effort only.
>>>> Hi Anant,
>>>>
>>>> I see you are testing lots of USB bugs. USB subsystem is currently
>>>> broken, testing of any USB bugs will give false "no crash" results,
>>>> see:
>>>> https://lore.kernel.org/linux-kernel-mentees/CACT4Y+YmbmrH9gCCnCzP-FYa-dKxx9qhKZ+RQxi1f-+Hoj1SUg@mail.gmail.com/
>>> Fixes for this USB problem are in my tree now and should show up in
>>> linux-next on Monday.
>>>
>>> thanks,
>>>
>>> greg k-h
>> Is there any chance you could identify the commit that fixes this bug?
>> It would help us close the bug for good. :)
> I think Greg meant the fix for the general USB brokenness, not a fix
> for this syzbot bug. This bug is not fixed to the best of syzbot
> knowledge.

Ah, okay. My bad. I was wondering why the bug wasn't closed already
if there was already a fix. Thank you for clearing that up :)

Thanks,
Anant