2019-12-04 01:12:15

by Mao Wenan

Subject: [PATCH -next] MIPS: Loongson2ef: drop pointless static qualifier in loongson_suspend_enter()

There is no need to have the 'T *v' variable static
since new value always be assigned before use it.

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Mao Wenan <[email protected]>
---
arch/mips/loongson2ef/common/pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/mips/loongson2ef/common/pm.c b/arch/mips/loongson2ef/common/pm.c
index 11f4cfd581fb..bcb7ae9777cf 100644
--- a/arch/mips/loongson2ef/common/pm.c
+++ b/arch/mips/loongson2ef/common/pm.c
@@ -91,7 +91,7 @@ static inline void stop_perf_counters(void)

static void loongson_suspend_enter(void)
{
- static unsigned int cached_cpu_freq;
+ unsigned int cached_cpu_freq;

/* setup wakeup events via enabling the IRQs */
setup_wakeup_events();
--
2.20.1

2020-01-09 21:03:46

by Paul Burton

Subject: Re: [PATCH -next] MIPS: Loongson2ef: drop pointless static qualifier in loongson_suspend_enter()

Hello,

Mao Wenan wrote:
> There is no need to have the 'T *v' variable static
> since new value always be assigned before use it.

Applied to mips-next.

> commit 11d06df7b9f2
> https://git.kernel.org/mips/c/11d06df7b9f2
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Mao Wenan <[email protected]>
> Signed-off-by: Paul Burton <[email protected]>

Thanks,
Paul

[ This message was auto-generated; if you believe anything is incorrect
then please email [email protected] to report it. ]