2023-07-28 10:29:34

by Nikita Shubin

[permalink] [raw]
Subject: Re: [PATCH v3 03/42] clk: ep93xx: add DT support for Cirrus EP93xx

Hello Stephen!

On Thu, 2023-07-20 at 16:27 -0700, Stephen Boyd wrote:
> Quoting Nikita Shubin via B4 Relay (2023-07-20 04:29:03)
>
> > +static int clk_hw_register_div(struct ep93xx_clk *clk,
> > +                                         const char *name,
> > +                                         const char *parent_name,
>
> Please try to pass a direct pointer to the parent clk_hw instead or
> if
> the clk exists outside the controller pass a DT index.

I'll use parent_data everywhere, however i currently can't pass "xtali"
as index, as: 

- moved all clk's that are not used via device tree to SoC driver 
https://lore.kernel.org/b4-sent/[email protected]/

and SoC driver isn't a OF clock provider, should i make it clock
provider as well ?