2013-07-02 16:23:51

by Yann Droneaud

[permalink] [raw]
Subject: [PATCH] MAINTAINERS: [email protected] is a list

This patch changes type of [email protected]

The output of ./scripts/get_maintainer.pl is
modified to report [email protected] as a list:

Ben Myers <[email protected]> (supporter:XFS FILESYSTEM)
Alex Elder <[email protected]> (supporter:XFS FILESYSTEM)
[email protected] (supporter:XFS FILESYSTEM)
[email protected] (open list:XFS FILESYSTEM)
[email protected] (open list)

Signed-off-by: Yann Droneaud <[email protected]>
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ad7e322..7b6ab51 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9139,7 +9139,6 @@ XFS FILESYSTEM
P: Silicon Graphics Inc
M: Ben Myers <[email protected]>
M: Alex Elder <[email protected]>
-M: [email protected]
L: [email protected]
W: http://oss.sgi.com/projects/xfs
T: git git://oss.sgi.com/xfs/xfs.git
--
1.8.3.1


2013-07-03 06:41:10

by Dave Chinner

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: [email protected] is a list

On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote:
> This patch changes type of [email protected]
>
> The output of ./scripts/get_maintainer.pl is
> modified to report [email protected] as a list:

What's the problem with that? All XFS patches and problem
reports should be sent to the [email protected] list. There are far
more people than just the maintainer that can triage problems,
answer questions and review patches...

Cheers,

Dave.
--
Dave Chinner
[email protected]

2013-07-03 08:25:28

by Yann Droneaud

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: [email protected] is a list

Hi,

Le 03.07.2013 08:40, Dave Chinner a écrit :
> On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote:
>> This patch changes type of [email protected]
>>
>> The output of ./scripts/get_maintainer.pl is
>> modified to report [email protected] as a list:
>
> What's the problem with that? All XFS patches and problem
> reports should be sent to the [email protected] list. There are far
> more people than just the maintainer that can triage problems,
> answer questions and review patches...
>

It was just disturbing: I was looking for a list for XFS
and found only maintainers.
Except dm-devel, no others public mailing list is used as a maintainer.
So I thought it was a misinterpretation after following commit:

commit 18caa67ad41212e6f82a675c40f461ffb45f098e
Author: Ben Myers <[email protected]>
Date: Thu Apr 12 17:05:05 2012 +0000

MAINTAINERS: retire [email protected]

[email protected] will be retired in favor of [email protected]
sometime soon.

Signed-off-by: Ben Myers <[email protected]>
Reviewed-by: Christoph Hellwig <[email protected]>

diff --git a/MAINTAINERS b/MAINTAINERS
index 2dcfca8..12b0445 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7564,7 +7564,7 @@ XFS FILESYSTEM
P: Silicon Graphics Inc
M: Ben Myers <[email protected]>
M: Alex Elder <[email protected]>
-M: [email protected]
+M: [email protected]
L: [email protected]
W: http://oss.sgi.com/projects/xfs
T: git git://oss.sgi.com/xfs/xfs.git


Regards.

--
Yann Droneaud
OPTEYA

2013-07-03 09:24:14

by Dave Chinner

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: [email protected] is a list

On Wed, Jul 03, 2013 at 10:14:41AM +0200, Yann Droneaud wrote:
> Hi,
>
> Le 03.07.2013 08:40, Dave Chinner a ?crit?:
> >On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote:
> >>This patch changes type of [email protected]
> >>
> >>The output of ./scripts/get_maintainer.pl is
> >>modified to report [email protected] as a list:
> >
> >What's the problem with that? All XFS patches and problem
> >reports should be sent to the [email protected] list. There are far
> >more people than just the maintainer that can triage problems,
> >answer questions and review patches...
> >
>
> It was just disturbing: I was looking for a list for XFS
> and found only maintainers.

That's what the:

L: [email protected]

entry is, yes?

Cheers,

Dave.
--
Dave Chinner
[email protected]

2013-07-03 09:36:43

by Yann Droneaud

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: [email protected] is a list

Le 03.07.2013 11:24, Dave Chinner a écrit :
> On Wed, Jul 03, 2013 at 10:14:41AM +0200, Yann Droneaud wrote:
>> Le 03.07.2013 08:40, Dave Chinner a écrit :
>> >On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote:
>> >>This patch changes type of [email protected]
>> >>
>> >>The output of ./scripts/get_maintainer.pl is
>> >>modified to report [email protected] as a list:
>> >
>> >What's the problem with that? All XFS patches and problem
>> >reports should be sent to the [email protected] list. There are far
>> >more people than just the maintainer that can triage problems,
>> >answer questions and review patches...
>> >
>>
>> It was just disturbing: I was looking for a list for XFS
>> and found only maintainers.
>
> That's what the:
>
> L: [email protected]
>
> entry is, yes?
>

In the output of ./scripts/get_maintainer.pl:

Ben Myers <[email protected]> (supporter:XFS FILESYSTEM)
Alex Elder <[email protected]> (supporter:XFS FILESYSTEM)
[email protected] (supporter:XFS FILESYSTEM)
[email protected] (open list)

[If having the mailing list listed as the maintainer/supporter is
correct,
could ./scripts/get_maintainer.pl also report the mailing list as a
list ?]

Regards.

--
Yann Droneaud
OPTEYA

2013-07-03 09:50:57

by Dave Chinner

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: [email protected] is a list

On Wed, Jul 03, 2013 at 11:36:39AM +0200, Yann Droneaud wrote:
> Le 03.07.2013 11:24, Dave Chinner a ?crit?:
> >On Wed, Jul 03, 2013 at 10:14:41AM +0200, Yann Droneaud wrote:
> >>Le 03.07.2013 08:40, Dave Chinner a ?crit?:
> >>>On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote:
> >>>>This patch changes type of [email protected]
> >>>>
> >>>>The output of ./scripts/get_maintainer.pl is
> >>>>modified to report [email protected] as a list:
> >>>
> >>>What's the problem with that? All XFS patches and problem
> >>>reports should be sent to the [email protected] list. There are far
> >>>more people than just the maintainer that can triage problems,
> >>>answer questions and review patches...
> >>>
> >>
> >>It was just disturbing: I was looking for a list for XFS
> >>and found only maintainers.
> >
> >That's what the:
> >
> >L: [email protected]
> >
> >entry is, yes?
> >
>
> In the output of ./scripts/get_maintainer.pl:
>
> Ben Myers <[email protected]> (supporter:XFS FILESYSTEM)
> Alex Elder <[email protected]> (supporter:XFS FILESYSTEM)
> [email protected] (supporter:XFS FILESYSTEM)
> [email protected] (open list)

You're smarter than a dumb script. If the information that the
script parses is correct and the dumb script doesn't give you the
right information, then what needs fixing?

Seriously, all you are proving is the old adage that
scripts/get_maintainer.pl should be considered harmful because
people use it without first engaging their brain.

Cheers,

Dave.
--
Dave Chinner
[email protected]

2013-07-03 09:54:12

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: [email protected] is a list

On Wed, 2013-07-03 at 11:36 +0200, Yann Droneaud wrote:
> In the output of ./scripts/get_maintainer.pl:
>
> Ben Myers <[email protected]> (supporter:XFS FILESYSTEM)
> Alex Elder <[email protected]> (supporter:XFS FILESYSTEM)
> [email protected] (supporter:XFS FILESYSTEM)
> [email protected] (open list)
>
> [If having the mailing list listed as the maintainer/supporter is
> correct,
> could ./scripts/get_maintainer.pl also report the mailing list as a
> list ?]

It does when you ask for just the lists...

$ ./scripts/get_maintainer.pl -f -l -nom fs/xfs
[email protected] (open list:XFS FILESYSTEM)
[email protected] (open list)

If it bothers you that the same email address
doesn't get reported as both a maintainer and
a mailing list, you're free to submit a patch
to get_maintainer.pl. (look at sub add_role)

It doesn't bother me.

2013-07-03 10:07:42

by Yann Droneaud

[permalink] [raw]
Subject: Re: [PATCH] MAINTAINERS: [email protected] is a list

Le 03.07.2013 11:50, Dave Chinner a écrit :
> On Wed, Jul 03, 2013 at 11:36:39AM +0200, Yann Droneaud wrote:
>> Le 03.07.2013 11:24, Dave Chinner a écrit :
>> >On Wed, Jul 03, 2013 at 10:14:41AM +0200, Yann Droneaud wrote:
>> >>Le 03.07.2013 08:40, Dave Chinner a écrit :
>> >>>On Tue, Jul 02, 2013 at 05:00:47PM +0200, Yann Droneaud wrote:
>> >>>>This patch changes type of [email protected]
>> >>>>
>> >>>>The output of ./scripts/get_maintainer.pl is
>> >>>>modified to report [email protected] as a list:
>> >>>
>> >>>What's the problem with that? All XFS patches and problem
>> >>>reports should be sent to the [email protected] list. There are far
>> >>>more people than just the maintainer that can triage problems,
>> >>>answer questions and review patches...
>> >>>
>> >>
>> >>It was just disturbing: I was looking for a list for XFS
>> >>and found only maintainers.
>> >
>> >That's what the:
>> >
>> >L: [email protected]
>> >
>> >entry is, yes?
>> >
>>
>> In the output of ./scripts/get_maintainer.pl:
>>
>> Ben Myers <[email protected]> (supporter:XFS FILESYSTEM)
>> Alex Elder <[email protected]> (supporter:XFS FILESYSTEM)
>> [email protected] (supporter:XFS FILESYSTEM)
>> [email protected] (open list)
>
> You're smarter than a dumb script. If the information that the
> script parses is correct and the dumb script doesn't give you the
> right information, then what needs fixing?
>

And what about:

If you are the only one[*] to abuse ./scripts/get_maintainer.pl,
then what needs fixing ?

[*] I have found three other examples of duplicating mailing list as
maintainer:

$ sed -n 's/^L:[[:space:]]*//p' MAINTAINERS | sort | uniq > L
$ sed -n 's/^M:[[:space:]]*//p' MAINTAINERS | sort | uniq > M
$ comm -12 L M
[email protected]
[email protected]
[email protected]

I've sent a patch for [email protected] and [email protected],
in my first pass I've missed [email protected]

> Seriously, all you are proving is the old adage that
> scripts/get_maintainer.pl should be considered harmful because
> people use it without first engaging their brain.

Just thinking about the whole picture.
In this case ./scripts/get_maintainer.pl is going to be right most of
time
except for 3 subsystems on about 1160. So having the same address for
maintainer
and list is a rather uncommon case. Which could be misleading for most.

Regards.

--
Yann Droneaud
OPTEYA