2022-08-15 12:41:44

by Tom Fitzhenry

Subject: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings

Document board compatible names for Pine64 PinePhonePro.

https://wiki.pine64.org/wiki/PinePhone_Pro

Signed-off-by: Tom Fitzhenry <[email protected]>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 7811ba64149cb..8ddedbd1ce317 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -494,6 +494,11 @@ properties:
- const: pine64,pinenote
- const: rockchip,rk3566

+ - description: Pine64 PinePhonePro
+ items:
+ - const: pine64,pinephone-pro
+ - const: rockchip,rk3399
+
- description: Pine64 Rock64
items:
- const: pine64,rock64
--
2.37.1

2022-08-16 05:42:49

by Caleb Connolly

Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings

On 15/08/2022 13:30, Tom Fitzhenry wrote:
> Document board compatible names for Pine64 PinePhonePro.
>
> https://wiki.pine64.org/wiki/PinePhone_Pro
>
> Signed-off-by: Tom Fitzhenry <[email protected]>

Reviewed-by: Caleb Connolly <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 7811ba64149cb..8ddedbd1ce317 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -494,6 +494,11 @@ properties:
> - const: pine64,pinenote
> - const: rockchip,rk3566
>
> + - description: Pine64 PinePhonePro
> + items:
> + - const: pine64,pinephone-pro
> + - const: rockchip,rk3399
> +
> - description: Pine64 Rock64
> items:
> - const: pine64,rock64
> --
> 2.37.1
>

2022-08-16 10:16:18

by Krzysztof Kozlowski

Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add PinePhone Pro bindings

On 15/08/2022 15:30, Tom Fitzhenry wrote:
> Document board compatible names for Pine64 PinePhonePro.
>
> https://wiki.pine64.org/wiki/PinePhone_Pro
>
> Signed-off-by: Tom Fitzhenry <[email protected]>

Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.


Acked-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof