2022-08-09 14:36:31

by Shenwei Wang

Subject: [PATCH v2 1/3] dt-bindings: gpio: Add imx-scu gpio driver bindings

Add binding document for the imx-scu gpio driver.

Signed-off-by: Shenwei Wang <[email protected]>
---
.../bindings/gpio/fsl,imx8-scu-gpio.yaml | 39 +++++++++++++++++++
1 file changed, 39 insertions(+)
create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml

diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
new file mode 100644
index 000000000000..4cbe3108a612
--- /dev/null
+++ b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
@@ -0,0 +1,39 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/gpio/fsl,imx8-scu-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO driver over IMX SCU firmware API
+
+maintainers:
+ - Shenwei Wang <[email protected]>
+
+description: |
+ This module provides the standard interface to control the
+ resource pins in SCU domain on i.MX8 platforms.
+
+properties:
+ compatible:
+ enum:
+ - fsl,imx8-scu-gpio
+
+ "#gpio-cells":
+ const: 2
+
+ gpio-controller: true
+
+required:
+ - compatible
+ - "#gpio-cells"
+ - gpio-controller
+
+additionalProperties: false
+
+examples:
+ - |
+ gpio0: gpio {
+ compatible = "fsl,imx8-scu-gpio";
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
--
2.25.1

2022-08-09 16:33:17

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 1/3] dt-bindings: gpio: Add imx-scu gpio driver bindings

On 09/08/2022 17:31, Shenwei Wang wrote:
> Add binding document for the imx-scu gpio driver.
>
> Signed-off-by: Shenwei Wang <[email protected]>
> ---
> .../bindings/gpio/fsl,imx8-scu-gpio.yaml | 39 +++++++++++++++++++
> 1 file changed, 39 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
>
> diff --git a/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
> new file mode 100644
> index 000000000000..4cbe3108a612
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/gpio/fsl,imx8-scu-gpio.yaml
> @@ -0,0 +1,39 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/gpio/fsl,imx8-scu-gpio.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GPIO driver over IMX SCU firmware API
> +
> +maintainers:
> + - Shenwei Wang <[email protected]>
> +
> +description: |
> + This module provides the standard interface to control the
> + resource pins in SCU domain on i.MX8 platforms.
> +
> +properties:
> + compatible:
> + enum:
> + - fsl,imx8-scu-gpio

This should be rather a specific imx8 chip. See other imx8 SCU bindings.
Strictly speaking there is no "imx8" SoC and compatible should be
derived from SoC.



Best regards,
Krzysztof

2022-08-09 19:33:14

by Shenwei Wang

Subject: RE: [EXT] Re: [PATCH v2 1/3] dt-bindings: gpio: Add imx-scu gpio driver bindings

> -----Original Message-----
> From: Krzysztof Kozlowski <[email protected]>
> Sent: Tuesday, August 9, 2022 11:05 AM
> To: Shenwei Wang <[email protected]>; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; dl-linux-imx <[email protected]>
> Cc: [email protected]; [email protected]; linux-
> [email protected]; [email protected]; [email protected]
> Subject: [EXT] Re: [PATCH v2 1/3] dt-bindings: gpio: Add imx-scu gpio driver
> > +properties:
> > + compatible:
> > + enum:
> > + - fsl,imx8-scu-gpio
>
> This should be rather a specific imx8 chip. See other imx8 SCU bindings.
> Strictly speaking there is no "imx8" SoC and compatible should be derived from
> SoC.

Make sense. Thank you very much for the comments.

Regards
Shenwei

>
>
>
> Best regards,
> Krzysztof