2022-07-04 19:08:50

by Colin Ian King

Subject: [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r

The assignment to variable r is duplicated, the second assignment
is redundant and can be removed.

Signed-off-by: Colin Ian King <[email protected]>
---
fs/ntfs3/run.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ntfs3/run.c b/fs/ntfs3/run.c
index 7609d45a2d72..aba8ab1b9fcb 100644
--- a/fs/ntfs3/run.c
+++ b/fs/ntfs3/run.c
@@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
e = run->runs + run->count;
r = run->runs + index;

- r = run->runs + index;
if (vcn > r->vcn)
r += 1;

--
2.35.3

2022-07-05 14:29:51

by Konstantin Komarov

Subject: Re: [PATCH][next] fs/ntfs3: remove duplicated assignment to variable r

On 7/4/22 21:53, Colin Ian King wrote:
> The assignment to variable r is duplicated, the second assignment
> is redundant and can be removed.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/ntfs3/run.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ntfs3/run.c b/fs/ntfs3/run.c
> index 7609d45a2d72..aba8ab1b9fcb 100644
> --- a/fs/ntfs3/run.c
> +++ b/fs/ntfs3/run.c
> @@ -563,7 +563,6 @@ bool run_insert_range(struct runs_tree *run, CLST vcn, CLST len)
> e = run->runs + run->count;
> r = run->runs + index;
>
> - r = run->runs + index;
> if (vcn > r->vcn)
> r += 1;
>

Thanks for patch, applied!