2019-07-30 11:01:29

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH] dma-mapping: remove dma_{alloc,free,mmap}_writecombine

On 30/07/2019 09:18, Christoph Hellwig wrote:
> We can already use DMA_ATTR_WRITE_COMBINE or the _wc prefixed version,
> so remove the third way of doing things.
>
> Signed-off-by: Christoph Hellwig <[email protected]>
> ---
> drivers/gpu/drm/omapdrm/dss/dispc.c | 11 +++++------
> include/linux/dma-mapping.h | 9 ---------
> 2 files changed, 5 insertions(+), 15 deletions(-)

Reviewed-by: Tomi Valkeinen <[email protected]>

Which tree should this be applied to?

Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki


2019-07-30 11:51:09

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] dma-mapping: remove dma_{alloc,free,mmap}_writecombine

On Tue, Jul 30, 2019 at 10:50:32AM +0300, Tomi Valkeinen wrote:
> On 30/07/2019 09:18, Christoph Hellwig wrote:
>> We can already use DMA_ATTR_WRITE_COMBINE or the _wc prefixed version,
>> so remove the third way of doing things.
>>
>> Signed-off-by: Christoph Hellwig <[email protected]>
>> ---
>> drivers/gpu/drm/omapdrm/dss/dispc.c | 11 +++++------
>> include/linux/dma-mapping.h | 9 ---------
>> 2 files changed, 5 insertions(+), 15 deletions(-)
>
> Reviewed-by: Tomi Valkeinen <[email protected]>
>
> Which tree should this be applied to?

I'd like to add it to the dma-mapping tree if possible.

2019-07-30 12:13:52

by Tomi Valkeinen

[permalink] [raw]
Subject: Re: [PATCH] dma-mapping: remove dma_{alloc,free,mmap}_writecombine

On 30/07/2019 13:20, Christoph Hellwig wrote:
> On Tue, Jul 30, 2019 at 10:50:32AM +0300, Tomi Valkeinen wrote:
>> On 30/07/2019 09:18, Christoph Hellwig wrote:
>>> We can already use DMA_ATTR_WRITE_COMBINE or the _wc prefixed version,
>>> so remove the third way of doing things.
>>>
>>> Signed-off-by: Christoph Hellwig <[email protected]>
>>> ---
>>> drivers/gpu/drm/omapdrm/dss/dispc.c | 11 +++++------
>>> include/linux/dma-mapping.h | 9 ---------
>>> 2 files changed, 5 insertions(+), 15 deletions(-)
>>
>> Reviewed-by: Tomi Valkeinen <[email protected]>
>>
>> Which tree should this be applied to?
>
> I'd like to add it to the dma-mapping tree if possible.

That's ok for me.

Tomi

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki