Hi,
Neither Thomas nor myself much liked that futex2.c nor do we think that CONFIG_
symbol makes much sense.
However, futex.c is a wee bit long and splitting it up makes sense. So I've
taken the liberty to replace your initial patch with 15 of my own and then
rebased the remaining patches on top of that.
Thomas, does something like this work for you?
Hi Peter,
Às 11:07 de 15/09/21, Peter Zijlstra escreveu:
> Hi,
>
> Neither Thomas nor myself much liked that futex2.c nor do we think that CONFIG_
> symbol makes much sense.
>
> However, futex.c is a wee bit long and splitting it up makes sense. So I've
> taken the liberty to replace your initial patch with 15 of my own and then
> rebased the remaining patches on top of that.
>
Thank you for doing that. futex.c is indeed too big and I believe that
this really make the code easier to read, and the way you organized
makes more sense than the way I did. Maybe even robust could have a
separated file?
Thanks,
André
Às 11:07 de 15/09/21, Peter Zijlstra escreveu:
> Hi,
>
> Neither Thomas nor myself much liked that futex2.c nor do we think that CONFIG_
> symbol makes much sense.
>
> However, futex.c is a wee bit long and splitting it up makes sense. So I've
> taken the liberty to replace your initial patch with 15 of my own and then
> rebased the remaining patches on top of that.
>
> Thomas, does something like this work for you?
>
I tested this patchset:
- On top of a full distro
- Using futex kselftests
- Running glibc's nptl tests, all 387 passed
It seems that things are working as expected. You can add my
Reviewed-by: André Almeida <[email protected]>
for patches 01 - 15.