2020-11-09 07:06:15

by Menglong Dong

[permalink] [raw]
Subject: [PATCH] net: sched: fix misspellings using misspell-fixer tool

From: Menglong Dong <[email protected]>

Some typos are found out by misspell-fixer tool:

$ misspell-fixer -rnv ./net/sched/
./net/sched/act_api.c:686
./net/sched/act_bpf.c:68
./net/sched/cls_rsvp.h:241
./net/sched/em_cmp.c:44
./net/sched/sch_pie.c:408

Fix typos found by misspell-fixer.

Signed-off-by: Menglong Dong <[email protected]>
---
net/sched/act_api.c | 2 +-
net/sched/act_bpf.c | 2 +-
net/sched/cls_rsvp.h | 2 +-
net/sched/em_cmp.c | 2 +-
net/sched/sch_pie.c | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/net/sched/act_api.c b/net/sched/act_api.c
index 1341c59c2f40..60e1572ba606 100644
--- a/net/sched/act_api.c
+++ b/net/sched/act_api.c
@@ -683,7 +683,7 @@ static struct tc_action_ops *tc_lookup_action(struct nlattr *kind)
return res;
}

-/*TCA_ACT_MAX_PRIO is 32, there count upto 32 */
+/*TCA_ACT_MAX_PRIO is 32, there count up to 32 */
#define TCA_ACT_MAX_PRIO_MASK 0x1FF
int tcf_action_exec(struct sk_buff *skb, struct tc_action **actions,
int nr_actions, struct tcf_result *res)
diff --git a/net/sched/act_bpf.c b/net/sched/act_bpf.c
index a4c7ba35a343..e48e980c3b93 100644
--- a/net/sched/act_bpf.c
+++ b/net/sched/act_bpf.c
@@ -65,7 +65,7 @@ static int tcf_bpf_act(struct sk_buff *skb, const struct tc_action *act,
* In case a different well-known TC_ACT opcode has been
* returned, it will overwrite the default one.
*
- * For everything else that is unkown, TC_ACT_UNSPEC is
+ * For everything else that is unknown, TC_ACT_UNSPEC is
* returned.
*/
switch (filter_res) {
diff --git a/net/sched/cls_rsvp.h b/net/sched/cls_rsvp.h
index d36949d9382c..2e288f88ff02 100644
--- a/net/sched/cls_rsvp.h
+++ b/net/sched/cls_rsvp.h
@@ -238,7 +238,7 @@ static void rsvp_replace(struct tcf_proto *tp, struct rsvp_filter *n, u32 h)
}
}

- /* Something went wrong if we are trying to replace a non-existant
+ /* Something went wrong if we are trying to replace a non-existent
* node. Mind as well halt instead of silently failing.
*/
BUG_ON(1);
diff --git a/net/sched/em_cmp.c b/net/sched/em_cmp.c
index a4d09b1fb66a..f17b049ea530 100644
--- a/net/sched/em_cmp.c
+++ b/net/sched/em_cmp.c
@@ -41,7 +41,7 @@ static int em_cmp_match(struct sk_buff *skb, struct tcf_ematch *em,
break;

case TCF_EM_ALIGN_U32:
- /* Worth checking boundries? The branching seems
+ /* Worth checking boundaries? The branching seems
* to get worse. Visit again.
*/
val = get_unaligned_be32(ptr);
diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c
index c65077f0c0f3..5a457ff61acd 100644
--- a/net/sched/sch_pie.c
+++ b/net/sched/sch_pie.c
@@ -405,7 +405,7 @@ void pie_calculate_probability(struct pie_params *params, struct pie_vars *vars,
/* We restart the measurement cycle if the following conditions are met
* 1. If the delay has been low for 2 consecutive Tupdate periods
* 2. Calculated drop probability is zero
- * 3. If average dq_rate_estimator is enabled, we have atleast one
+ * 3. If average dq_rate_estimator is enabled, we have at least one
* estimate for the avg_dq_rate ie., is a non-zero value
*/
if ((vars->qdelay < params->target / 2) &&
--
2.25.1



2020-11-09 21:27:28

by John Fastabend

[permalink] [raw]
Subject: RE: [PATCH] net: sched: fix misspellings using misspell-fixer tool

menglong8.dong@ wrote:
> From: Menglong Dong <[email protected]>
>
> Some typos are found out by misspell-fixer tool:
>
> $ misspell-fixer -rnv ./net/sched/
> ./net/sched/act_api.c:686
> ./net/sched/act_bpf.c:68
> ./net/sched/cls_rsvp.h:241
> ./net/sched/em_cmp.c:44
> ./net/sched/sch_pie.c:408
>
> Fix typos found by misspell-fixer.
>
> Signed-off-by: Menglong Dong <[email protected]>
> ---

Hi, you will want to add net-next to the [PATCH *] line next time
to make it clear this is for net-next. The contents make it
obvious in this case though.

Also I'm not sure why the bpf@ include but OK.

Acked-by: John Fastabend <[email protected]>

2020-11-10 15:40:01

by Menglong Dong

[permalink] [raw]
Subject: Re: [PATCH] net: sched: fix misspellings using misspell-fixer tool

Hi, John.

On Tue, Nov 10, 2020 at 5:23 AM John Fastabend <[email protected]> wrote:
>
> Hi, you will want to add net-next to the [PATCH *] line next time
> to make it clear this is for net-next. The contents make it
> obvious in this case though.
>
> Also I'm not sure why the bpf@ include but OK.

Thanks for your suggestion, and I will pay attention to the [PATCH *] next time.

As for the bpf@, I guess that 'get_maintainer.pl' listed it to me
because of 'act_bpf.c'.

Cheers,
Menglong Dong

2020-11-11 01:06:18

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] net: sched: fix misspellings using misspell-fixer tool

On Mon, 9 Nov 2020 02:02:17 -0500 [email protected] wrote:
> From: Menglong Dong <[email protected]>
>
> Some typos are found out by misspell-fixer tool:
>
> $ misspell-fixer -rnv ./net/sched/
> ./net/sched/act_api.c:686
> ./net/sched/act_bpf.c:68
> ./net/sched/cls_rsvp.h:241
> ./net/sched/em_cmp.c:44
> ./net/sched/sch_pie.c:408
>
> Fix typos found by misspell-fixer.
>
> Signed-off-by: Menglong Dong <[email protected]>

Applied, thanks.