2022-03-09 01:14:35

by Janis Schoetterl-Glausch

Subject: [PATCH RESEND v2 0/5] memop selftest for storage key checking

Refactor memop selftest and add tests.
Add storage key tests, both for success as well as failure cases.
Similarly, test both vcpu and vm ioctls.

v1 -> v2
* restructure commits
* get rid of test_* wrapper functions that hid vm.vm
* minor changes

v0 -> v2
* complete rewrite

v1: https://lore.kernel.org/kvm/[email protected]/
v0: https://lore.kernel.org/kvm/[email protected]/

Janis Schoetterl-Glausch (5):
KVM: s390: selftests: Split memop tests
KVM: s390: selftests: Add macro as abstraction for MEM_OP
KVM: s390: selftests: Add named stages for memop test
KVM: s390: selftests: Add more copy memop tests
KVM: s390: selftests: Add error memop tests

tools/testing/selftests/kvm/s390x/memop.c | 735 ++++++++++++++++++----
1 file changed, 617 insertions(+), 118 deletions(-)


base-commit: ee6a569d3bf64c9676eee3eecb861fb01cc11311
--
2.32.0

2022-03-09 09:22:35

by Christian Borntraeger

Subject: Re: [PATCH RESEND v2 0/5] memop selftest for storage key checking

Am 08.03.22 um 13:58 schrieb Janis Schoetterl-Glausch:
> Refactor memop selftest and add tests.
> Add storage key tests, both for success as well as failure cases.
> Similarly, test both vcpu and vm ioctls.
>
> v1 -> v2
> * restructure commits
> * get rid of test_* wrapper functions that hid vm.vm
> * minor changes
>
> v0 -> v2
> * complete rewrite
>
> v1: https://lore.kernel.org/kvm/[email protected]/
> v0: https://lore.kernel.org/kvm/[email protected]/
>
> Janis Schoetterl-Glausch (5):
> KVM: s390: selftests: Split memop tests
> KVM: s390: selftests: Add macro as abstraction for MEM_OP
> KVM: s390: selftests: Add named stages for memop test
> KVM: s390: selftests: Add more copy memop tests
> KVM: s390: selftests: Add error memop tests
>
> tools/testing/selftests/kvm/s390x/memop.c | 735 ++++++++++++++++++----
> 1 file changed, 617 insertions(+), 118 deletions(-)
>
>
> base-commit: ee6a569d3bf64c9676eee3eecb861fb01cc11311

applied (with minor whitespace fixes). Will queue for kvms390/next.

2022-03-09 11:35:38

by Janis Schoetterl-Glausch

Subject: Re: [PATCH RESEND v2 0/5] memop selftest for storage key checking

On 3/9/22 10:05, Christian Borntraeger wrote:
> Am 08.03.22 um 13:58 schrieb Janis Schoetterl-Glausch:
>> Refactor memop selftest and add tests.
>> Add storage key tests, both for success as well as failure cases.
>> Similarly, test both vcpu and vm ioctls.
>>
>> v1 -> v2
>>   * restructure commits
>>   * get rid of test_* wrapper functions that hid vm.vm
>>   * minor changes
>>
>> v0 -> v2
>>   * complete rewrite
>>
>> v1: https://lore.kernel.org/kvm/[email protected]/
>> v0: https://lore.kernel.org/kvm/[email protected]/
>>
>> Janis Schoetterl-Glausch (5):
>>    KVM: s390: selftests: Split memop tests
>>    KVM: s390: selftests: Add macro as abstraction for MEM_OP
>>    KVM: s390: selftests: Add named stages for memop test
>>    KVM: s390: selftests: Add more copy memop tests
>>    KVM: s390: selftests: Add error memop tests
>>
>>   tools/testing/selftests/kvm/s390x/memop.c | 735 ++++++++++++++++++----
>>   1 file changed, 617 insertions(+), 118 deletions(-)
>>
>>
>> base-commit: ee6a569d3bf64c9676eee3eecb861fb01cc11311
>
> applied (with minor whitespace fixes). Will queue for kvms390/next.

Not sure if it's a good idea, but I broke style rules here intentionally:

+ CHECK_N_DO(MOP, t.vcpu, LOGICAL, READ, mem2, PAGE_SIZE + 2048,
+ GADDR_V(guest_last_page), KEY(2));

in order to emphasize that the arguments are ultimately arguments to MOP.
I did the same in the DEFAULT(_WRITE)?_READ macros, which checkpatch might
not warn about because of the line break escapes.