2023-02-27 05:35:13

by srinivas pandruvada

Subject: [PATCH] platform/x86: ISST: Increase range of valid mail box commands

A new command CONFIG_TDP_GET_RATIO_INFO is added, with sub command type
of 0x0C. The previous range of valid sub commands was from 0x00 to 0x0B.
Change the valid range from 0x00 to 0x0C.

Signed-off-by: Srinivas Pandruvada <[email protected]>
---
drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
index a7e02b24a87a..0829e793a8fc 100644
--- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
+++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
@@ -47,7 +47,7 @@ struct isst_cmd_set_req_type {

static const struct isst_valid_cmd_ranges isst_valid_cmds[] = {
{0xD0, 0x00, 0x03},
- {0x7F, 0x00, 0x0B},
+ {0x7F, 0x00, 0x0C},
{0x7F, 0x10, 0x12},
{0x7F, 0x20, 0x23},
{0x94, 0x03, 0x03},
--
2.39.1

2023-03-01 12:43:45

by Hans de Goede

Subject: Re: [PATCH] platform/x86: ISST: Increase range of valid mail box commands

Hi,

On 2/27/23 06:35, Srinivas Pandruvada wrote:
> A new command CONFIG_TDP_GET_RATIO_INFO is added, with sub command type
> of 0x0C. The previous range of valid sub commands was from 0x00 to 0x0B.
> Change the valid range from 0x00 to 0x0C.
>
> Signed-off-by: Srinivas Pandruvada <[email protected]>

Thanks, I've applied this patch to my review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

I'll rebase that branch once 6.3-rc1 is out and then push the rebased
patch to the fixes branch and include it in my next 6.3 fixes pull-req
to Linus.

Regards,

Hans





> ---
> drivers/platform/x86/intel/speed_select_if/isst_if_common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> index a7e02b24a87a..0829e793a8fc 100644
> --- a/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> +++ b/drivers/platform/x86/intel/speed_select_if/isst_if_common.c
> @@ -47,7 +47,7 @@ struct isst_cmd_set_req_type {
>
> static const struct isst_valid_cmd_ranges isst_valid_cmds[] = {
> {0xD0, 0x00, 0x03},
> - {0x7F, 0x00, 0x0B},
> + {0x7F, 0x00, 0x0C},
> {0x7F, 0x10, 0x12},
> {0x7F, 0x20, 0x23},
> {0x94, 0x03, 0x03},