2024-06-10 13:00:25

by Primoz Fiser

[permalink] [raw]
Subject: [PATCH v2] ASoC: ti: omap-hdmi: Fix too long driver name

Set driver name to "HDMI". This simplifies the code and gets rid of
the following error messages:

ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'

Signed-off-by: Primoz Fiser <[email protected]>
---
Changes in v2:
- use "HDMI" instead of DRV_NAME (requested)

sound/soc/ti/omap-hdmi.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
index 639bc83f4263..cf43ac19c4a6 100644
--- a/sound/soc/ti/omap-hdmi.c
+++ b/sound/soc/ti/omap-hdmi.c
@@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
if (!card)
return -ENOMEM;

- card->name = devm_kasprintf(dev, GFP_KERNEL,
- "HDMI %s", dev_name(ad->dssdev));
- if (!card->name)
- return -ENOMEM;
-
+ card->name = "HDMI";
card->owner = THIS_MODULE;
card->dai_link =
devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);
--
2.25.1



2024-06-10 14:44:44

by Péter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH v2] ASoC: ti: omap-hdmi: Fix too long driver name

Hi,

On 6/10/24 3:58 PM, Primoz Fiser wrote:
> Set driver name to "HDMI". This simplifies the code and gets rid of
> the following error messages:
>
> ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'

Thank you for the update,
Acked-by: Peter Ujfalusi <[email protected]>

> Signed-off-by: Primoz Fiser <[email protected]>
> ---
> Changes in v2:
> - use "HDMI" instead of DRV_NAME (requested)
>
> sound/soc/ti/omap-hdmi.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/sound/soc/ti/omap-hdmi.c b/sound/soc/ti/omap-hdmi.c
> index 639bc83f4263..cf43ac19c4a6 100644
> --- a/sound/soc/ti/omap-hdmi.c
> +++ b/sound/soc/ti/omap-hdmi.c
> @@ -354,11 +354,7 @@ static int omap_hdmi_audio_probe(struct platform_device *pdev)
> if (!card)
> return -ENOMEM;
>
> - card->name = devm_kasprintf(dev, GFP_KERNEL,
> - "HDMI %s", dev_name(ad->dssdev));
> - if (!card->name)
> - return -ENOMEM;
> -
> + card->name = "HDMI";
> card->owner = THIS_MODULE;
> card->dai_link =
> devm_kzalloc(dev, sizeof(*(card->dai_link)), GFP_KERNEL);

--
Péter

2024-06-12 17:49:14

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v2] ASoC: ti: omap-hdmi: Fix too long driver name

On Mon, 10 Jun 2024 14:58:47 +0200, Primoz Fiser wrote:
> Set driver name to "HDMI". This simplifies the code and gets rid of
> the following error messages:
>
> ASoC: driver name too long 'HDMI 58040000.encoder' -> 'HDMI_58040000_e'
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: ti: omap-hdmi: Fix too long driver name
commit: 524d3f126362b6033e92cbe107ae2158d7fbff94

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark