2020-04-04 00:13:25

by Michał Mirosław

Subject: [PATCH] regulator: use consumer->supply_name in debugfs/regulator_summary

Make it easier to identify regulator consumers when consumer device
uses more than one supply.

Before:

regulator ena use open bypass voltage current min max
-----------------------------------------------------------------------------------
regulator-dummy 1 0 2 0 0mV 0mA 0mV 0mV
1-0010 0mV 0mV
1-0010 0mV 0mV

After:

regulator ena use open bypass voltage current min max
-----------------------------------------------------------------------------------
regulator-dummy 1 0 2 0 0mV 0mA 0mV 0mV
1-0010-vccio 0mV 0mV
1-0010-vcc33 0mV 0mV

Signed-off-by: Michał Mirosław <[email protected]>
---
drivers/regulator/core.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index c340505150b6..ad143004c32b 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -5496,6 +5496,7 @@ static void regulator_summary_show_subtree(struct seq_file *s,
seq_printf(s, "%*s%-*s ",
(level + 1) * 3 + 1, "",
30 - (level + 1) * 3,
+ consumer->supply_name ? consumer->supply_name :
consumer->dev ? dev_name(consumer->dev) : "deviceless");

switch (rdev->desc->type) {
--
2.20.1

2020-04-16 00:23:25

by Dmitry Osipenko

Subject: Re: [PATCH] regulator: use consumer->supply_name in debugfs/regulator_summary

04.04.2020 03:11, Michał Mirosław пишет:
> Make it easier to identify regulator consumers when consumer device
> uses more than one supply.
>
> Before:
>
> regulator ena use open bypass voltage current min max
> -----------------------------------------------------------------------------------
> regulator-dummy 1 0 2 0 0mV 0mA 0mV 0mV
> 1-0010 0mV 0mV
> 1-0010 0mV 0mV
>
> After:
>
> regulator ena use open bypass voltage current min max
> -----------------------------------------------------------------------------------
> regulator-dummy 1 0 2 0 0mV 0mA 0mV 0mV
> 1-0010-vccio 0mV 0mV
> 1-0010-vcc33 0mV 0mV
>
> Signed-off-by: Michał Mirosław <[email protected]>
> ---
> drivers/regulator/core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
> index c340505150b6..ad143004c32b 100644
> --- a/drivers/regulator/core.c
> +++ b/drivers/regulator/core.c
> @@ -5496,6 +5496,7 @@ static void regulator_summary_show_subtree(struct seq_file *s,
> seq_printf(s, "%*s%-*s ",
> (level + 1) * 3 + 1, "",
> 30 - (level + 1) * 3,
> + consumer->supply_name ? consumer->supply_name :
> consumer->dev ? dev_name(consumer->dev) : "deviceless");
>
> switch (rdev->desc->type) {
>

Hello Michał,

This is a very nice improvement, I like it!

Reviewed-by: Dmitry Osipenko <[email protected]>
Tested-by: Dmitry Osipenko <[email protected]>