2019-12-31 15:34:31

by Vladimir Oltean

[permalink] [raw]
Subject: Re: [PATCH RFC net-next 00/20] net: dsa: add GRO support

Hi Alexander,

On Mon, 30 Dec 2019 at 16:31, Alexander Lobakin <[email protected]> wrote:
>
> I mark this as RFC, and there are the key questions for maintainers,
> developers, users etc.:
> - Do we need GRO support for DSA at all?
> - Which tagger protocols really need it and which don't?
> - Does this series bring any performance improvements on the
> affected systems?

If these are these questions for maintainers, developers, users etc,
then what has determined you to make these changes?

Thanks,
-Vladimir


2020-01-13 09:31:42

by Alexander Lobakin

[permalink] [raw]
Subject: Re: [PATCH RFC net-next 00/20] net: dsa: add GRO support

Vladimir Oltean wrote 31.12.2019 18:32:
> Hi Alexander,

Hi,

> On Mon, 30 Dec 2019 at 16:31, Alexander Lobakin <[email protected]>
> wrote:
>>
>> I mark this as RFC, and there are the key questions for maintainers,
>> developers, users etc.:
>> - Do we need GRO support for DSA at all?
>> - Which tagger protocols really need it and which don't?
>> - Does this series bring any performance improvements on the
>> affected systems?
>
> If these are these questions for maintainers, developers, users etc,
> then what has determined you to make these changes?

The main reason was obviously pretty good results on a particular
hardware on which I developed this (and other) series and a general
opinion that GRO improves overall performance on most systems.
DSA is a special case though.

> Thanks,
> -Vladimir

Regards,
ᚷ ᛖ ᚢ ᚦ ᚠ ᚱ