2020-01-08 15:42:49

by chenzhou

Subject: [PATCH next] drm/i915/gtt: add missing include file asm/smp.h

Fix build error:
lib/crypto/chacha.c: In function chacha_permute:
lib/crypto/chacha.c:65:1: warning: the frame size of 3384 bytes is larger than 2048 bytes [-Wframe-larger-than=]
}
^

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Chen Zhou <[email protected]>
---
drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
index 1a2b5dc..9ef8ed8 100644
--- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
+++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
@@ -6,6 +6,7 @@
#include <linux/stop_machine.h>

#include <asm/set_memory.h>
+#include <asm/smp.h>

#include "intel_gt.h"
#include "i915_drv.h"
--
2.7.4

2020-01-08 15:42:56

by Jani Nikula

Subject: Re: [PATCH next] drm/i915/gtt: add missing include file asm/smp.h

On Wed, 08 Jan 2020, Chen Zhou <[email protected]> wrote:
> Fix build error:
> lib/crypto/chacha.c: In function chacha_permute:
> lib/crypto/chacha.c:65:1: warning: the frame size of 3384 bytes is larger than 2048 bytes [-Wframe-larger-than=]
> }
> ^

IMO this needs a better explanation of why not having the include leads
to the above failure.

BR,
Jani.

>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Chen Zhou <[email protected]>
> ---
> drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> index 1a2b5dc..9ef8ed8 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> @@ -6,6 +6,7 @@
> #include <linux/stop_machine.h>
>
> #include <asm/set_memory.h>
> +#include <asm/smp.h>
>
> #include "intel_gt.h"
> #include "i915_drv.h"

--
Jani Nikula, Intel Open Source Graphics Center

2020-01-08 15:43:44

by chenzhou

Subject: Re: [PATCH next] drm/i915/gtt: add missing include file asm/smp.h

On 2020/1/8 21:44, Jani Nikula wrote:
> On Wed, 08 Jan 2020, Chen Zhou <[email protected]> wrote:
>> Fix build error:
>> lib/crypto/chacha.c: In function chacha_permute:
>> lib/crypto/chacha.c:65:1: warning: the frame size of 3384 bytes is larger than 2048 bytes [-Wframe-larger-than=]
>> }
>> ^
>
> IMO this needs a better explanation of why not having the include leads
> to the above failure.
>
> BR,
> Jani.
>

Sorry, i made a mistake. The error is as follows:

drivers/gpu/drm/i915/gt/intel_ggtt.c: In function ggtt_restore_mappings:
drivers/gpu/drm/i915/gt/intel_ggtt.c:1239:3: error: implicit declaration of function wbinvd_on_all_cpus; did you mean wrmsr_on_cpus? [-Werror=implicit-function-declaration]
wbinvd_on_all_cpus();
^~~~~~~~~~~~~~~~~~
wrmsr_on_cpus


Thanks,
Chen Zhou

>>
>> Reported-by: Hulk Robot <[email protected]>
>> Signed-off-by: Chen Zhou <[email protected]>
>> ---
>> drivers/gpu/drm/i915/gt/intel_ggtt.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
>> index 1a2b5dc..9ef8ed8 100644
>> --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
>> +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
>> @@ -6,6 +6,7 @@
>> #include <linux/stop_machine.h>
>>
>> #include <asm/set_memory.h>
>> +#include <asm/smp.h>
>>
>> #include "intel_gt.h"
>> #include "i915_drv.h"
>