2021-09-21 01:25:47

by Ville Baillie

Subject: RE: [PATCH v3] spi: atmel: Fix PDC transfer setup bug

From 626b32a8db5b1904b0f0f7781e2375b2fd17a497 Mon Sep 17 00:00:00 2001
From: Ville Baillie <[email protected]>
Date: Thu, 16 Sep 2021 14:16:46 +0000
Subject: [PATCH v3] spi: atmel: Fix PDC transfer setup bug

Commit 5fa5e6dec762 ("spi: atmel: Switch to transfer_one transfer
method") refactored the code and changed a conditional causing
atmel_spi_dma_map_xfer to never be called in PDC mode. This causes the
driver to silently fail.

This patch changes the conditional to match the behaviour of the
previous commit before the refactor.

Signed-off-by: Ville Baillie <[email protected]>
---
drivers/spi/spi-atmel.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c
index 788dcdf25f00..f872cf196c2f 100644
--- a/drivers/spi/spi-atmel.c
+++ b/drivers/spi/spi-atmel.c
@@ -1301,7 +1301,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
* DMA map early, for performance (empties dcache ASAP) and
* better fault reporting.
*/
- if ((!master->cur_msg_mapped)
+ if ((!master->cur_msg->is_dma_mapped)
&& as->use_pdc) {
if (atmel_spi_dma_map_xfer(as, xfer) < 0)
return -ENOMEM;
@@ -1381,7 +1381,7 @@ static int atmel_spi_one_transfer(struct spi_master *master,
}
}

- if (!master->cur_msg_mapped
+ if (!master->cur_msg->is_dma_mapped
&& as->use_pdc)
atmel_spi_dma_unmap_xfer(master, xfer);

--
2.17.1

2021-09-21 01:27:17

by Ville Baillie

Subject: RE: [PATCH v3] spi: atmel: Fix PDC transfer setup bug

My apologies, it appears my email client is mangling the patch.

I will resend if I can get 'git send-email' working.

Thanks
Ville