2021-08-03 09:38:57

by kernel test robot

[permalink] [raw]
Subject: [arnd-playground:net-space-cleanup 7/14] drivers/net/ethernet/8390/ax88796.c:104:6: warning: no previous prototype for 'ax_NS8390_reinit'

tree: https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git net-space-cleanup
head: c230d36d10203e5b1af6ddccc7b134601acc3504
commit: b1842abab6ad1eb689fa11b0f95ac815101b331a [7/14] [net-next] ax88796: export ax_NS8390_init() hook
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 10.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git/commit/?id=b1842abab6ad1eb689fa11b0f95ac815101b331a
git remote add arnd-playground https://git.kernel.org/pub/scm/linux/kernel/git/arnd/playground.git
git fetch --no-tags arnd-playground net-space-cleanup
git checkout b1842abab6ad1eb689fa11b0f95ac815101b331a
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-10.3.0 make.cross ARCH=m68k

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/8390/ax88796.c:104:6: warning: no previous prototype for 'ax_NS8390_reinit' [-Wmissing-prototypes]
104 | void ax_NS8390_reinit(struct net_device *dev)
| ^~~~~~~~~~~~~~~~


vim +/ax_NS8390_reinit +104 drivers/net/ethernet/8390/ax88796.c

103
> 104 void ax_NS8390_reinit(struct net_device *dev)
105 {
106 ax_NS8390_init(dev, 1);
107 }
108

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]


Attachments:
(No filename) (1.67 kB)
.config.gz (59.89 kB)
Download all attachments

2021-08-03 10:35:50

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [arnd-playground:net-space-cleanup 7/14] drivers/net/ethernet/8390/ax88796.c:104:6: warning: no previous prototype for 'ax_NS8390_reinit'

On Tue, Aug 3, 2021 at 11:35 AM kernel test robot <[email protected]> wrote:
> All warnings (new ones prefixed by >>):
>
> >> drivers/net/ethernet/8390/ax88796.c:104:6: warning: no previous prototype for 'ax_NS8390_reinit' [-Wmissing-prototypes]
> 104 | void ax_NS8390_reinit(struct net_device *dev)
> | ^~~~~~~~~~~~~~~~
>
>
> vim +/ax_NS8390_reinit +104 drivers/net/ethernet/8390/ax88796.c
>
> 103
> > 104 void ax_NS8390_reinit(struct net_device *dev)
> 105 {
> 106 ax_NS8390_init(dev, 1);
> 107 }
> 108

I'll resend the series in a bit, fixed up this warning by moving the
declaration to include/net/ax88796.h.

Arnd

2021-08-04 01:37:36

by Michael Schmitz

[permalink] [raw]
Subject: Re: [arnd-playground:net-space-cleanup 7/14] drivers/net/ethernet/8390/ax88796.c:104:6: warning: no previous prototype for 'ax_NS8390_reinit'

Hi Arnd,

On 3/08/21 10:31 pm, Arnd Bergmann wrote:
> On Tue, Aug 3, 2021 at 11:35 AM kernel test robot <[email protected]> wrote:
>> All warnings (new ones prefixed by >>):
>>
>>>> drivers/net/ethernet/8390/ax88796.c:104:6: warning: no previous prototype for 'ax_NS8390_reinit' [-Wmissing-prototypes]
>> 104 | void ax_NS8390_reinit(struct net_device *dev)
>> | ^~~~~~~~~~~~~~~~
>>
>>
>> vim +/ax_NS8390_reinit +104 drivers/net/ethernet/8390/ax88796.c
>>
>> 103
>> > 104 void ax_NS8390_reinit(struct net_device *dev)
>> 105 {
>> 106 ax_NS8390_init(dev, 1);
>> 107 }
>> 108
> I'll resend the series in a bit, fixed up this warning by moving the
> declaration to include/net/ax88796.h.

Thanks for taking care of this - I had lost track of that patch altogether.

Cheers,

    Michael


>
> Arnd