2007-09-25 17:24:29

by Jan Engelhardt

Subject: Re: Linux 2.6.22.8, pata_ali issue

On Sep 25 2007 19:21, Oliver Pinter wrote:
>
>the rev is locali declared:
>
>[snap]
>
> ...
>
>static void ali_init_chipset(struct pci_dev *pdev)
>{
> u8 rev, tmp;
> struct pci_dev *north, *isa_bridge;
>
> pci_read_config_byte(pdev, PCI_REVISION_ID, &rev);
>
> ...
>
>[snap]
>
>what's the git id in git tree?

Huh? My top git is 4942de4a0e914f205d351a81873f4f63986bcc3c
and it has this:

static void ali_init_chipset(struct pci_dev *pdev)
{
u8 tmp;
struct pci_dev *north, *isa_bridge;

/*
* The chipset revision selects the driver operations and
* mode data.
*/

if (pdev->revision >= 0x20 && pdev->revision < 0xC2) {


No pci_read_config_byte here..

2007-09-25 17:25:45

by Oliver Pinter

Subject: Re: Linux 2.6.22.8, pata_ali issue

my git top is:

commit 0dc661f882011b941b8b4d4dac84d7a0371f7a7b
Author: Greg Kroah-Hartman <[email protected]>
Date: Mon Sep 24 23:05:13 2007 -0700

Linux 2.6.22.8


On 9/25/07, Jan Engelhardt <[email protected]> wrote:
>
> On Sep 25 2007 19:21, Oliver Pinter wrote:
> >
> >the rev is locali declared:
> >
> >[snap]
> >
> > ...
> >
> >static void ali_init_chipset(struct pci_dev *pdev)
> >{
> > u8 rev, tmp;
> > struct pci_dev *north, *isa_bridge;
> >
> > pci_read_config_byte(pdev, PCI_REVISION_ID, &rev);
> >
> > ...
> >
> >[snap]
> >
> >what's the git id in git tree?
>
> Huh? My top git is 4942de4a0e914f205d351a81873f4f63986bcc3c
> and it has this:
>
> static void ali_init_chipset(struct pci_dev *pdev)
>
> {
>
> u8 tmp;
>
> struct pci_dev *north, *isa_bridge;
>
>
> /*
>
> * The chipset revision selects the driver operations and
>
> * mode data.
>
> */
>
>
> if (pdev->revision >= 0x20 && pdev->revision < 0xC2) {
>
>
>
> No pci_read_config_byte here..
>
>


--
Thanks,
Oliver

2007-09-25 17:27:16

by Oliver Pinter

Subject: Re: Linux 2.6.22.8, pata_ali issue

hey, your's tree is 2.6-git and not 2.6.22.8 ;)


On 9/25/07, Oliver Pinter <[email protected]> wrote:
> my git top is:
>
> commit 0dc661f882011b941b8b4d4dac84d7a0371f7a7b
> Author: Greg Kroah-Hartman <[email protected]>
> Date: Mon Sep 24 23:05:13 2007 -0700
>
> Linux 2.6.22.8
>
>
> On 9/25/07, Jan Engelhardt <[email protected]> wrote:
> >
> > On Sep 25 2007 19:21, Oliver Pinter wrote:
> > >
> > >the rev is locali declared:
> > >
> > >[snap]
> > >
> > > ...
> > >
> > >static void ali_init_chipset(struct pci_dev *pdev)
> > >{
> > > u8 rev, tmp;
> > > struct pci_dev *north, *isa_bridge;
> > >
> > > pci_read_config_byte(pdev, PCI_REVISION_ID, &rev);
> > >
> > > ...
> > >
> > >[snap]
> > >
> > >what's the git id in git tree?
> >
> > Huh? My top git is 4942de4a0e914f205d351a81873f4f63986bcc3c
> > and it has this:
> >
> > static void ali_init_chipset(struct pci_dev *pdev)
> >
> > {
> >
> > u8 tmp;
> >
> > struct pci_dev *north, *isa_bridge;
> >
> >
> > /*
> >
> > * The chipset revision selects the driver operations and
> >
> > * mode data.
> >
> > */
> >
> >
> > if (pdev->revision >= 0x20 && pdev->revision < 0xC2) {
> >
> >
> >
> > No pci_read_config_byte here..
> >
> >
>
>
> --
> Thanks,
> Oliver
>


--
Thanks,
Oliver