On 05/04/2024 11:01, Neeraj Sanjay Kale wrote:
> This adds a new optional device tree property called firware-name.
> If this property is specified, the driver overrides the firmware
> name hardcoded in the driver source code.
>
> Signed-off-by: Neeraj Sanjay Kale <[email protected]>
> ---
> .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> index f01a3988538c..25c258212bcd 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> @@ -31,6 +31,13 @@ properties:
> This property depends on the module vendor's
> configuration.
>
> + firmware-name:
> + $ref: /schemas/types.yaml#/definitions/string
drop, missing maxItems. Look at recent code.
> + description:
> + Specify firmware file name, prepended with nxp/.
Why with nxp? What if firmware is stored somewhere else?
> + This property overrides the firmware names hardcoded
> + in the driver source code.
Drop, you now describe current OS policy. What if U-boot treats it
differently?
Best regards,
Krzysztof