2021-08-13 06:00:33

by Shunsuke Mie

[permalink] [raw]
Subject: [PATCH] RDMA/rxe: Remove duplicate umem assignment

While initialization of rxe_mr, mr->umem is assigned duplicate. Remove
the redundant code.

Signed-off-by: Shunsuke Mie <[email protected]>
---
drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 73bbafd32554..6e2e0da2e50d 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
goto err1;
}

- mr->umem = umem;
num_buf = ib_umem_num_pages(umem);

rxe_mr_init(access, mr);
--
2.25.1


2021-08-13 11:54:59

by Xiao Yang

[permalink] [raw]
Subject: Re: [PATCH] RDMA/rxe: Remove duplicate umem assignment

Hi,

My same fix[1] has been merged into for-next branch on rdma but it is
not merged into mainline for now.

[1]:
https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f

Best Regards,
Xiao Yang

On 2021/8/13 13:57, Shunsuke Mie wrote:
> While initialization of rxe_mr, mr->umem is assigned duplicate. Remove
> the redundant code.
>
> Signed-off-by: Shunsuke Mie <[email protected]>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 73bbafd32554..6e2e0da2e50d 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -122,7 +122,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
> goto err1;
> }
>
> - mr->umem = umem;
> num_buf = ib_umem_num_pages(umem);
>
> rxe_mr_init(access, mr);

2021-08-16 01:47:52

by Shunsuke Mie

[permalink] [raw]
Subject: Re: [PATCH] RDMA/rxe: Remove duplicate umem assignment

HI, Xiao.

> My same fix[1] has been merged into for-next branch on rdma but it is
> not merged into mainline for now.
>
> [1]:
> https://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git/commit/?id=cdbdb7724740f62d11519679e11cf673cd9d6c8f
Thank you for the information. I had missed it.

Thanks a lot,
Shunsuke Mie