Hi all,
After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:
drivers/net/ll_temac_main.c: In function 'll_temac_recv':
drivers/net/ll_temac_main.c:695: error: implicit declaration of function 'virt_to_bus'
Caused by commit 459569145516f7967b916c57445feb02c600668c ("Add
non-Virtex5 support for LL TEMAC driver") from the net tree.
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
From: Stephen Rothwell <[email protected]>
Date: Thu, 8 Apr 2010 15:35:05 +1000
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/net/ll_temac_main.c: In function 'll_temac_recv':
> drivers/net/ll_temac_main.c:695: error: implicit declaration of function 'virt_to_bus'
>
> Caused by commit 459569145516f7967b916c57445feb02c600668c ("Add
> non-Virtex5 support for LL TEMAC driver") from the net tree.
>
> I have reverted that commit for today.
And I'm reverting it too, it's illegal to use virt_to_bus()
in new code in this day and age.
John, you'll need to use the DMA mapping APIs in this change when you
resubmit it.
Thanks.
> -----Original Message-----
> From: David Miller [mailto:[email protected]]
> Sent: Thursday, April 08, 2010 12:25 AM
> To: [email protected]
> Cc: [email protected]; [email protected];
[email protected]; John Linn;
> [email protected]
> Subject: Re: linux-next: build failure after merge of the final tree
>
> From: Stephen Rothwell <[email protected]>
> Date: Thu, 8 Apr 2010 15:35:05 +1000
>
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/net/ll_temac_main.c: In function 'll_temac_recv':
> > drivers/net/ll_temac_main.c:695: error: implicit declaration of
function 'virt_to_bus'
> >
> > Caused by commit 459569145516f7967b916c57445feb02c600668c ("Add
> > non-Virtex5 support for LL TEMAC driver") from the net tree.
> >
> > I have reverted that commit for today.
>
> And I'm reverting it too, it's illegal to use virt_to_bus()
> in new code in this day and age.
I'm not pushing back here, just trying to make sure I understand and do
it better next time :)
I don't see that my patch has touched that part of the driver as that
call was already in the driver before my patch (but maybe I'm just
missing it).
My patch did change the dependency in the Kconfig so that it only
depends on powerpc rather than powerpc DCR and maybe that exposed
something that wasn't previously exposed.
Maybe this is an issue in linux-next and I need to test against that,
I'm pulling it now. I was testing against Linus's tree.
>
> John, you'll need to use the DMA mapping APIs in this change when you
> resubmit it.
Thanks, will spin it again and get that fixed. My apologies for the
hassles, appreciate the help.
-- John
>
> Thanks.
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
Hi John,
On Thu, 8 Apr 2010 08:15:12 -0600 John Linn <[email protected]> wrote:
>
> I'm not pushing back here, just trying to make sure I understand and do
> it better next time :)
>
> I don't see that my patch has touched that part of the driver as that
> call was already in the driver before my patch (but maybe I'm just
> missing it).
>
> My patch did change the dependency in the Kconfig so that it only
> depends on powerpc rather than powerpc DCR and maybe that exposed
> something that wasn't previously exposed.
Yeah, virt_to_bus() is only defined on 32bit PowerPC, not 64 bit.
CONFIG_PPC is set for both 32 and 64 bit PowerPC builds.
--
Cheers,
Stephen Rothwell [email protected]
http://www.canb.auug.org.au/~sfr/
> -----Original Message-----
> From: Stephen Rothwell [mailto:[email protected]]
> Sent: Thursday, April 08, 2010 4:59 PM
> To: John Linn
> Cc: David Miller; [email protected]; [email protected];
[email protected];
> [email protected]; [email protected]
> Subject: Re: linux-next: build failure after merge of the final tree
>
> Hi John,
>
> On Thu, 8 Apr 2010 08:15:12 -0600 John Linn <[email protected]>
wrote:
> >
> > I'm not pushing back here, just trying to make sure I understand and
> > do it better next time :)
> >
> > I don't see that my patch has touched that part of the driver as
that
> > call was already in the driver before my patch (but maybe I'm just
> > missing it).
> >
> > My patch did change the dependency in the Kconfig so that it only
> > depends on powerpc rather than powerpc DCR and maybe that exposed
> > something that wasn't previously exposed.
>
> Yeah, virt_to_bus() is only defined on 32bit PowerPC, not 64 bit.
>
> CONFIG_PPC is set for both 32 and 64 bit PowerPC builds.
> --
Thanks for confirming that. Spun a new patch (set) to hopefully take
care of that.
-- John
> Cheers,
> Stephen Rothwell [email protected]
> http://www.canb.auug.org.au/~sfr/
This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.