2024-04-01 15:41:39

by Christophe JAILLET

[permalink] [raw]
Subject: [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll

In "struct lpc18xx_pll", the 'lock' field is unused.
Remove it.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.
---
drivers/clk/nxp/clk-lpc18xx-cgu.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/nxp/clk-lpc18xx-cgu.c b/drivers/clk/nxp/clk-lpc18xx-cgu.c
index 69ebf65081b8..81efa885069b 100644
--- a/drivers/clk/nxp/clk-lpc18xx-cgu.c
+++ b/drivers/clk/nxp/clk-lpc18xx-cgu.c
@@ -250,7 +250,6 @@ static struct lpc18xx_cgu_base_clk lpc18xx_cgu_base_clks[] = {
struct lpc18xx_pll {
struct clk_hw hw;
void __iomem *reg;
- spinlock_t *lock;
u8 flags;
};

--
2.44.0



2024-04-04 15:46:45

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll

Quoting Christophe JAILLET (2024-04-01 08:31:53)
> In "struct lpc18xx_pll", the 'lock' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Applied to clk-next

2024-04-04 16:58:15

by Vladimir Zapolskiy

[permalink] [raw]
Subject: Re: [PATCH] clk: nxp: Remove an unused field in struct lpc18xx_pll

On 4/1/24 18:31, Christophe JAILLET wrote:
> In "struct lpc18xx_pll", the 'lock' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Thank you for the change!

Acked-by: Vladimir Zapolskiy <[email protected]>

--
Best wishes,
Vladimir