SPI protocol standardized by the TCG is described in the TCG PTP
specification 1.3 (chapter 6.4.6 SPI Bit Protocol), It was published by
TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf.
The TPM version number in the help message is wrong, which will
cause confusion. This patch fixes it.
Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
Signed-off-by: Tianjia Zhang <[email protected]>
---
drivers/char/tpm/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
index 58b4c573d176..8eedb3e704f3 100644
--- a/drivers/char/tpm/Kconfig
+++ b/drivers/char/tpm/Kconfig
@@ -62,7 +62,7 @@ config TCG_TIS_SPI
help
If you have a TPM security chip which is connected to a regular,
non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
- TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
+ TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
specification (TPM2.0) say Yes and it will be accessible from
within Linux. To compile this driver as a module, choose M here;
the module will be called tpm_tis_spi.
--
2.17.1
On Mon, Jul 27, 2020 at 10:22 AM Tianjia Zhang
<[email protected]> wrote:
>
> SPI protocol standardized by the TCG is described in the TCG PTP
> specification 1.3 (chapter 6.4.6 SPI Bit Protocol), It was published by
> TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf.
I'm still not convinced you got this right, the document you cite only
seems to mention TPM 1.2 as the base for TIS 1.3, but not TPM 1.3.
Arnd
> The TPM version number in the help message is wrong, which will
> cause confusion. This patch fixes it.
>
> Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
> Signed-off-by: Tianjia Zhang <[email protected]>
> ---
> drivers/char/tpm/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
> index 58b4c573d176..8eedb3e704f3 100644
> --- a/drivers/char/tpm/Kconfig
> +++ b/drivers/char/tpm/Kconfig
> @@ -62,7 +62,7 @@ config TCG_TIS_SPI
> help
> If you have a TPM security chip which is connected to a regular,
> non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
> - TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
> + TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
> specification (TPM2.0) say Yes and it will be accessible from
> within Linux. To compile this driver as a module, choose M here;
> the module will be called tpm_tis_spi.
> --
> 2.17.1
>
On 2020/7/27 16:32, Arnd Bergmann wrote:
> On Mon, Jul 27, 2020 at 10:22 AM Tianjia Zhang
> <[email protected]> wrote:
>>
>> SPI protocol standardized by the TCG is described in the TCG PTP
>> specification 1.3 (chapter 6.4.6 SPI Bit Protocol), It was published by
>> TCG_PCClientTPMInterfaceSpecification_TIS__1-3_27_03212013.pdf.
>
> I'm still not convinced you got this right, the document you cite only
> seems to mention TPM 1.2 as the base for TIS 1.3, but not TPM 1.3.
>
> Arnd
>
You are right, I was careless, thanks for your reply.
Thanks and best,
Tianjia
>> The TPM version number in the help message is wrong, which will
>> cause confusion. This patch fixes it.
>>
>> Fixes: 0edbfea537d1 ("tpm/tpm_tis_spi: Add support for spi phy")
>> Signed-off-by: Tianjia Zhang <[email protected]>
>> ---
>> drivers/char/tpm/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/char/tpm/Kconfig b/drivers/char/tpm/Kconfig
>> index 58b4c573d176..8eedb3e704f3 100644
>> --- a/drivers/char/tpm/Kconfig
>> +++ b/drivers/char/tpm/Kconfig
>> @@ -62,7 +62,7 @@ config TCG_TIS_SPI
>> help
>> If you have a TPM security chip which is connected to a regular,
>> non-tcg SPI master (i.e. most embedded platforms) that is compliant with the
>> - TCG TIS 1.3 TPM specification (TPM1.2) or the TCG PTP FIFO
>> + TCG TIS 1.3 TPM specification (TPM1.3) or the TCG PTP FIFO
>> specification (TPM2.0) say Yes and it will be accessible from
>> within Linux. To compile this driver as a module, choose M here;
>> the module will be called tpm_tis_spi.
>> --
>> 2.17.1
>>