2023-11-30 17:31:44

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH 8/8] parisc: Reduce size of __bug_table[] on 64-bit kernel by half

On Fri, Nov 24, 2023 at 03:41:13PM +0100, [email protected] wrote:
> From: Helge Deller <[email protected]>
>
> Enable GENERIC_BUG_RELATIVE_POINTERS which will store 32-bit relative
> offsets to the bug address and the source file name instead of 64-bit
> absolute addresses. This effectively reduces the size of the
> __bug_table[] array by half on 64-bit kernels.
>
> Signed-off-by: Helge Deller <[email protected]>

With this patch in mainline, parisc:tinyconfig fails to build.

ecurity/commoncap.c: In function 'cap_capset':
arch/parisc/include/asm/bug.h:71:17: error: invalid 'asm': operand number out of range
71 | asm volatile("\n" \
| ^~~

and many similar errors. Bisect log attached.

Guenter

---
# bad: [3b47bc037bd44f142ac09848e8d3ecccc726be99] Merge tag 'pinctrl-v6.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl
# good: [98b1cc82c4affc16f5598d4fa14b1858671b2263] Linux 6.7-rc2
git bisect start 'HEAD' 'v6.7-rc2'
# good: [f1a09972a45ae63efbd1587337c4be13b1893330] Merge tag 'ata-6.7-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata
git bisect good f1a09972a45ae63efbd1587337c4be13b1893330
# good: [090472ed9c922e699dc61dd601a9b376a64f4390] Merge tag 'usb-6.7-rc3' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb
git bisect good 090472ed9c922e699dc61dd601a9b376a64f4390
# bad: [2cc14f52aeb78ce3f29677c2de1f06c0e91471ab] Linux 6.7-rc3
git bisect bad 2cc14f52aeb78ce3f29677c2de1f06c0e91471ab
# good: [4892711acee0915a8a4ae02e1af3dc70ce000024] Merge tag 'x86-urgent-2023-11-26' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect good 4892711acee0915a8a4ae02e1af3dc70ce000024
# bad: [43266838515d30dc0c45d5c7e6e7edacee6cce92] parisc: Reduce size of the bug_table on 64-bit kernel by half
git bisect bad 43266838515d30dc0c45d5c7e6e7edacee6cce92
# good: [07eecff8ae78df7f28800484d31337e1f9bfca3a] parisc: Mark jump_table naturally aligned
git bisect good 07eecff8ae78df7f28800484d31337e1f9bfca3a
# good: [c9fcb2b65c2849e8ff3be23fd8828312fb68dc19] parisc: Ensure 32-bit alignment on parisc unwind section
git bisect good c9fcb2b65c2849e8ff3be23fd8828312fb68dc19
# good: [e5f3e299a2b1e9c3ece24a38adfc089aef307e8a] parisc: Drop the HP-UX ENOSYM and EREMOTERELEASE error codes
git bisect good e5f3e299a2b1e9c3ece24a38adfc089aef307e8a
# first bad commit: [43266838515d30dc0c45d5c7e6e7edacee6cce92] parisc: Reduce size of the bug_table on 64-bit kernel by half


2023-11-30 19:01:27

by Helge Deller

[permalink] [raw]
Subject: Re: [PATCH 8/8] parisc: Reduce size of __bug_table[] on 64-bit kernel by half

On 11/30/23 18:30, Guenter Roeck wrote:
> On Fri, Nov 24, 2023 at 03:41:13PM +0100, [email protected] wrote:
>> From: Helge Deller <[email protected]>
>>
>> Enable GENERIC_BUG_RELATIVE_POINTERS which will store 32-bit relative
>> offsets to the bug address and the source file name instead of 64-bit
>> absolute addresses. This effectively reduces the size of the
>> __bug_table[] array by half on 64-bit kernels.
>>
>> Signed-off-by: Helge Deller <[email protected]>
>
> With this patch in mainline, parisc:tinyconfig fails to build.
>
> ecurity/commoncap.c: In function 'cap_capset':
> arch/parisc/include/asm/bug.h:71:17: error: invalid 'asm': operand number out of range
> 71 | asm volatile("\n" \
> | ^~~
>
> and many similar errors. Bisect log attached.

Yes, problem was reported already and fix is in my for-next git tree:

https://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git/commit/?h=for-next&id=487635756198cad563feb47539c6a37ea57f1dae

Thanks!
Helge