2024-02-04 20:38:27

by Ricardo B. Marliere

[permalink] [raw]
Subject: [PATCH] spmi: make spmi_bus_type const

Now that the driver core can properly handle constant struct bus_type,
move the spmi_bus_type variable to be a constant structure as well,
placing it into read-only memory which can not be modified at runtime.

Cc: Greg Kroah-Hartman <[email protected]>
Suggested-by: Greg Kroah-Hartman <[email protected]>
Signed-off-by: Ricardo B. Marliere <[email protected]>
---
drivers/spmi/spmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
index 93cd4a34debc..401712726383 100644
--- a/drivers/spmi/spmi.c
+++ b/drivers/spmi/spmi.c
@@ -378,7 +378,7 @@ static int spmi_drv_uevent(const struct device *dev, struct kobj_uevent_env *env
return 0;
}

-static struct bus_type spmi_bus_type = {
+static const struct bus_type spmi_bus_type = {
.name = "spmi",
.match = spmi_device_match,
.probe = spmi_drv_probe,

---
base-commit: b85ea95d086471afb4ad062012a4d73cd328fa86
change-id: 20240204-bus_cleanup-spmi-ceaf77643663

Best regards,
--
Ricardo B. Marliere <[email protected]>



2024-02-05 19:14:52

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH] spmi: make spmi_bus_type const

On Sun, Feb 04, 2024 at 05:38:38PM -0300, Ricardo B. Marliere wrote:
> Now that the driver core can properly handle constant struct bus_type,
> move the spmi_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>

Reviewed-by: Greg Kroah-Hartman <[email protected]>

2024-04-08 02:58:36

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] spmi: make spmi_bus_type const

Quoting Ricardo B. Marliere (2024-02-04 12:38:38)
> Now that the driver core can properly handle constant struct bus_type,
> move the spmi_bus_type variable to be a constant structure as well,
> placing it into read-only memory which can not be modified at runtime.
>
> Cc: Greg Kroah-Hartman <[email protected]>
> Suggested-by: Greg Kroah-Hartman <[email protected]>
> Signed-off-by: Ricardo B. Marliere <[email protected]>
> ---

Applied to spmi-next