2023-07-20 11:40:30

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] can: ems_pci: move ASIX AX99100 ids to pci_ids.h

On 20.07.2023 10:28:59, Jiaqing Zhao wrote:
> Move PCI Vendor and Device ID of ASIX AX99100 PCIe to Multi I/O
> Controller to pci_ids.h for its serial and parallel port driver
> support in subsequent patches.

Sorry, I haven't noticed the change in "include/linux/pci_ids.h", that
the other patches depend on. How to coordinate among the subsystems?

I don't mind taking the entire (v1) series with the Acks from the
tty/serial and parport maintainers, or give my Acked-by to upstream
via their trees.

> Signed-off-by: Jiaqing Zhao <[email protected]>
> Reviewed-by: Andy Shevchenko <[email protected]>
> Acked-by: Bjorn Helgaas <[email protected]>
> ---
> drivers/net/can/sja1000/ems_pci.c | 6 +-----
> include/linux/pci_ids.h | 4 ++++
> 2 files changed, 5 insertions(+), 5 deletions(-)

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |


Attachments:
(No filename) (1.10 kB)
signature.asc (499.00 B)
Download all attachments

2023-07-20 16:10:44

by Jiaqing Zhao

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] can: ems_pci: move ASIX AX99100 ids to pci_ids.h

On 2023-07-20 18:40, Marc Kleine-Budde wrote:
> On 20.07.2023 10:28:59, Jiaqing Zhao wrote:
>> Move PCI Vendor and Device ID of ASIX AX99100 PCIe to Multi I/O
>> Controller to pci_ids.h for its serial and parallel port driver
>> support in subsequent patches.
>
> Sorry, I haven't noticed the change in "include/linux/pci_ids.h", that
> the other patches depend on. How to coordinate among the subsystems?
>
> I don't mind taking the entire (v1) series with the Acks from the
> tty/serial and parport maintainers, or give my Acked-by to upstream
> via their trees.

Add tty and parport maintainers to this thread.

I'd like to ask other maintainers' opinion as I'm not sure which option
is better and I had no similar experience before.

>> Signed-off-by: Jiaqing Zhao <[email protected]>
>> Reviewed-by: Andy Shevchenko <[email protected]>
>> Acked-by: Bjorn Helgaas <[email protected]>
>> ---
>> drivers/net/can/sja1000/ems_pci.c | 6 +-----
>> include/linux/pci_ids.h | 4 ++++
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> Marc
>

2023-07-24 06:52:31

by Jiaqing Zhao

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] can: ems_pci: move ASIX AX99100 ids to pci_ids.h



On 2023-07-20 18:40, Marc Kleine-Budde wrote:
> On 20.07.2023 10:28:59, Jiaqing Zhao wrote:
>> Move PCI Vendor and Device ID of ASIX AX99100 PCIe to Multi I/O
>> Controller to pci_ids.h for its serial and parallel port driver
>> support in subsequent patches.
>
> Sorry, I haven't noticed the change in "include/linux/pci_ids.h", that
> the other patches depend on. How to coordinate among the subsystems?
>
> I don't mind taking the entire (v1) series with the Acks from the
> tty/serial and parport maintainers, or give my Acked-by to upstream
> via their trees.

Since in ems_pci there are only definition changes, I think having your
Acked-by and upstream via the serial/parallel tree might be better.

>> Signed-off-by: Jiaqing Zhao <[email protected]>
>> Reviewed-by: Andy Shevchenko <[email protected]>
>> Acked-by: Bjorn Helgaas <[email protected]>
>> ---
>> drivers/net/can/sja1000/ems_pci.c | 6 +-----
>> include/linux/pci_ids.h | 4 ++++
>> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> Marc
>

2023-07-24 08:43:35

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] can: ems_pci: move ASIX AX99100 ids to pci_ids.h

On 24.07.2023 14:39:58, Jiaqing Zhao wrote:
>
>
> On 2023-07-20 18:40, Marc Kleine-Budde wrote:
> > On 20.07.2023 10:28:59, Jiaqing Zhao wrote:
> >> Move PCI Vendor and Device ID of ASIX AX99100 PCIe to Multi I/O
> >> Controller to pci_ids.h for its serial and parallel port driver
> >> support in subsequent patches.
> >
> > Sorry, I haven't noticed the change in "include/linux/pci_ids.h", that
> > the other patches depend on. How to coordinate among the subsystems?
> >
> > I don't mind taking the entire (v1) series with the Acks from the
> > tty/serial and parport maintainers, or give my Acked-by to upstream
> > via their trees.
>
> Since in ems_pci there are only definition changes, I think having your
> Acked-by and upstream via the serial/parallel tree might be better.

Fine with me. Please add my:

Acked-by: Marc Kleine-Budde <[email protected]>

to the patches 1 and 2.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |


Attachments:
(No filename) (1.17 kB)
signature.asc (499.00 B)
Download all attachments

2023-07-26 12:13:24

by Greg Kroah-Hartman

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] can: ems_pci: move ASIX AX99100 ids to pci_ids.h

On Thu, Jul 20, 2023 at 10:54:01PM +0800, Jiaqing Zhao wrote:
> On 2023-07-20 18:40, Marc Kleine-Budde wrote:
> > On 20.07.2023 10:28:59, Jiaqing Zhao wrote:
> >> Move PCI Vendor and Device ID of ASIX AX99100 PCIe to Multi I/O
> >> Controller to pci_ids.h for its serial and parallel port driver
> >> support in subsequent patches.
> >
> > Sorry, I haven't noticed the change in "include/linux/pci_ids.h", that
> > the other patches depend on. How to coordinate among the subsystems?
> >
> > I don't mind taking the entire (v1) series with the Acks from the
> > tty/serial and parport maintainers, or give my Acked-by to upstream
> > via their trees.
>
> Add tty and parport maintainers to this thread.
>
> I'd like to ask other maintainers' opinion as I'm not sure which option
> is better and I had no similar experience before.

Either is fine with me, I can just take them all through my tty tree as
that's simplest for me :)

thanks,

greg k-h

2023-07-26 12:26:59

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH v2 2/2] can: ems_pci: move ASIX AX99100 ids to pci_ids.h

On 26.07.2023 13:38:22, Greg Kroah-Hartman wrote:
> On Thu, Jul 20, 2023 at 10:54:01PM +0800, Jiaqing Zhao wrote:
> > On 2023-07-20 18:40, Marc Kleine-Budde wrote:
> > > On 20.07.2023 10:28:59, Jiaqing Zhao wrote:
> > >> Move PCI Vendor and Device ID of ASIX AX99100 PCIe to Multi I/O
> > >> Controller to pci_ids.h for its serial and parallel port driver
> > >> support in subsequent patches.
> > >
> > > Sorry, I haven't noticed the change in "include/linux/pci_ids.h", that
> > > the other patches depend on. How to coordinate among the subsystems?
> > >
> > > I don't mind taking the entire (v1) series with the Acks from the
> > > tty/serial and parport maintainers, or give my Acked-by to upstream
> > > via their trees.
> >
> > Add tty and parport maintainers to this thread.
> >
> > I'd like to ask other maintainers' opinion as I'm not sure which option
> > is better and I had no similar experience before.
>
> Either is fine with me, I can just take them all through my tty tree as
> that's simplest for me :)

Go ahead!

Acked-by: Marc Kleine-Budde <[email protected]>

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |


Attachments:
(No filename) (1.36 kB)
signature.asc (499.00 B)
Download all attachments